[
https://issues.apache.org/jira/browse/FLINK-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228704#comment-14228704
]
ASF GitHub Bot commented on FLINK-984:
--------------------------------------
GitHub user rmetzger opened a pull request:
https://github.com/apache/incubator-flink/pull/245
[FLINK-984] Compiler tests for distinct()
Adopted the old code from @markus-h
The code originates from https://github.com/apache/incubator-flink/pull/61.
The pull request also contained code to add POJO support to the distinct()
operator. This has already been implemented in earlier work
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/incubator-flink flink984
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit b47744605fd5d69981f94483bbf8407ca6fb7b6a
Author: Robert Metzger <[email protected]>
Date: 2014-11-25T15:26:12Z
[FLINK-984] Compiler tests for distinct(). Adopted the old code from
@markus-h
The code originates from https://github.com/apache/incubator-flink/pull/61.
The pull request also contained code to add POJO support to the distinct()
operator. This has already been implemented in earlier work
----
> Distinct operator for POJO DataSets without KeySelector and on
> UnsortedGrouping
> -------------------------------------------------------------------------------
>
> Key: FLINK-984
> URL: https://issues.apache.org/jira/browse/FLINK-984
> Project: Flink
> Issue Type: Improvement
> Reporter: Ufuk Celebi
> Assignee: Robert Metzger
> Priority: Minor
>
> Two issues regarding the distinct operator:
> - The distinct operator does not support {{distinct()}} with POJO datasets. I
> think it should be possible to implement a reflection based KeySelector which
> selects all public fields as key?
> - All other grouped operators work by {{groupBy(GROUPING).operator(...)}}
> whereas the distinct operator does {{distinct(GROUPING)}}. I think it would
> be more consistent to allow {{groupBy(GROUPING).distinct()}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
