[
https://issues.apache.org/jira/browse/FLINK-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14237315#comment-14237315
]
ASF GitHub Bot commented on FLINK-938:
--------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/248#discussion_r21429930
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManager.java
---
@@ -786,6 +786,13 @@ public static JobManager initialize(String[] args)
throws Exception {
// First, try to load global configuration
GlobalConfiguration.loadConfiguration(configDir);
+ // The configuretion does not contain a jobmanager address
+ if
(GlobalConfiguration.getString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
null) == null) {
+ Configuration c =
GlobalConfiguration.getConfiguration();
+
c.setString(ConfigConstants.JOB_MANAGER_IPC_ADDRESS_KEY,
InetAddress.getLocalHost().getHostName());
+ LOG.info("Setting jobmanager rpc address to " +
InetAddress.getLocalHost().getHostName());
+ GlobalConfiguration.includeConfiguration(c);
--- End diff --
I am still not a big fan of manipulating the global configuration. That is
an artifact of the singleton pattern that (which I think we should reduce and
get rid of eventually). I would pass the hostname as a proper parameter, not
through the config.
> Change start-cluster.sh script so that users don't have to configure the
> JobManager address
> -------------------------------------------------------------------------------------------
>
> Key: FLINK-938
> URL: https://issues.apache.org/jira/browse/FLINK-938
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Robert Metzger
> Assignee: Mingliang Qi
> Priority: Minor
> Fix For: 0.8-incubating
>
>
> To improve the user experience, Flink should not require users to configure
> the JobManager's address on a cluster.
> In combination with FLINK-934, this would allow running Flink with decent
> performance on a cluster without setting a single configuration value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
