[
https://issues.apache.org/jira/browse/FLINK-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240018#comment-14240018
]
ASF GitHub Bot commented on FLINK-986:
--------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/254#discussion_r21559978
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java
---
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.io.network.buffer;
+
+import org.apache.flink.core.memory.MemorySegment;
+
+import java.nio.ByteBuffer;
+import java.util.concurrent.atomic.AtomicInteger;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkNotNull;
+import static com.google.common.base.Preconditions.checkState;
+
+/**
+ * Wrapper for pooled {@link MemorySegment} instances.
+ */
+public class Buffer {
+
+ /** Size of the backing {@link MemorySegment} instance */
+ private final MemorySegment memorySegment;
+
+ /** The recycler for the backing {@link MemorySegment} */
+ private final BufferRecycler recycler;
+
+ /** The current number of references to this buffer */
+ private AtomicInteger referenceCount = new AtomicInteger(1);
+
+ /**
+ * The current size of the buffer in the range from 0 (inclusive) to the
+ * size of the backing {@link MemorySegment} (inclusive).
+ */
+ private AtomicInteger currentSize = new AtomicInteger();
+
+ public Buffer(MemorySegment memorySegment, BufferRecycler recycler) {
+ this.memorySegment = checkNotNull(memorySegment);
+ this.currentSize.set(memorySegment.size());
+ this.recycler = checkNotNull(recycler);
+ }
+
+ // TODO Revert serialized encoding of buffer or event type
+ public boolean isBuffer() {
+ ensureNotRecycled();
+
+ return memorySegment.getBoolean(0);
+ }
+
+ public MemorySegment getMemorySegment() {
+ ensureNotRecycled();
+
+ return memorySegment;
+ }
+
+ public ByteBuffer getNioBuffer() {
+ ensureNotRecycled();
+
+ return memorySegment.wrap(0, currentSize.get()).duplicate();
+ }
+
+ public int getSize() {
+ ensureNotRecycled();
+
+ return currentSize.get();
+ }
+
+ public void setSize(int newSize) {
+ ensureNotRecycled();
+
+ currentSize.set(checkSizeWithinBounds(newSize));
+ }
+
+ public void recycle() {
+ int current = referenceCount.decrementAndGet();
+
+ if (current == 0) {
+ recycler.recycle(memorySegment);
+ }
+ else if (current < 0) {
+ throw new IllegalStateException("Buffer has already
been recycled.");
+ }
+ }
+
+ public Buffer retain() {
+ ensureNotRecycled();
+
+ referenceCount.incrementAndGet();
+
+ return this;
+ }
+
+ public boolean isRecycled() {
+ return referenceCount.get() > 0;
--- End diff --
Yeah definitely, see above.
> Add intermediate results to distributed runtime
> -----------------------------------------------
>
> Key: FLINK-986
> URL: https://issues.apache.org/jira/browse/FLINK-986
> Project: Flink
> Issue Type: New Feature
> Components: Distributed Runtime
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Priority: Blocker
>
> Support for intermediate results in the runtime is currently blocking
> different efforts like fault tolerance or result collection at the client.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
