[
https://issues.apache.org/jira/browse/FLINK-998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243984#comment-14243984
]
ASF GitHub Bot commented on FLINK-998:
--------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/255#discussion_r21738066
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyConnectionManagerTest.java
---
@@ -127,7 +127,7 @@ public void run() {
while (seqNum.get() <
numToSendPerSubtask) {
try {
Envelope env = new
Envelope(seqNum.getAndIncrement(), jobId, channelId);
-
senderConnManager.enqueue(env, receiver);
+
senderConnManager.enqueue(env, receiver, seqNum.get() == 1);
--- End diff --
Is this on purpose, or a typo? In the connection manager , the first
envelope is marked by sequence number 0.
> NettyConnectionManager does not close connections
> -------------------------------------------------
>
> Key: FLINK-998
> URL: https://issues.apache.org/jira/browse/FLINK-998
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Runtime
> Affects Versions: pre-apache-0.5.1
> Reporter: Ufuk Celebi
> Assignee: Ufuk Celebi
> Priority: Critical
> Fix For: 0.6-incubating
>
>
> Network connections created via NettyConnectionManager are not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
