Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/255#discussion_r21738066
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyConnectionManagerTest.java
 ---
    @@ -127,7 +127,7 @@ public void run() {
                                        while (seqNum.get() < 
numToSendPerSubtask) {
                                                try {
                                                        Envelope env = new 
Envelope(seqNum.getAndIncrement(), jobId, channelId);
    -                                                   
senderConnManager.enqueue(env, receiver);
    +                                                   
senderConnManager.enqueue(env, receiver, seqNum.get() == 1);
    --- End diff --
    
    Is this on purpose, or a typo? In the connection manager , the first 
envelope is marked by sequence number 0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to