[
https://issues.apache.org/jira/browse/FLINK-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244127#comment-14244127
]
ASF GitHub Bot commented on FLINK-1245:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/203#discussion_r21743690
--- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
---
@@ -98,14 +99,18 @@ protected DataSet(ExecutionEnvironment context,
TypeInformation<T> type) {
throw new NullPointerException("context is null");
}
- if (type == null) {
- throw new NullPointerException("type is null");
- }
-
this.context = context;
this.type = type;
}
+ protected void setType(TypeInformation<T> type) {
--- End diff --
I would allow to set the type info twice, because of 2 reasons:
- If the type extractor extracts something wrong (what could happen due to
the complexity of POJOs), the user can use type hints as a workaround and
overwrite the wrong type extraction result.
- If the user uses lambdas in IntelliJ and gives TypeHints, he will get a
IllegalStateExpection when building the project with maven.
> Introduce TypeHints for Java API operators
> ------------------------------------------
>
> Key: FLINK-1245
> URL: https://issues.apache.org/jira/browse/FLINK-1245
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Timo Walther
> Assignee: Timo Walther
>
> Due to type extraction issues with Java 8 Lambdas and many users with type
> erasure issues, TypeHints need to be introduced.
> The whole discussion can be found on the mailing list:
> http://mail-archives.apache.org/mod_mbox/flink-dev/201410.mbox/%[email protected]%3E
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
