[ 
https://issues.apache.org/jira/browse/FLINK-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247943#comment-14247943
 ] 

ASF GitHub Bot commented on FLINK-1266:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/268#discussion_r21883696
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/core/fs/AbstractHadoopWrapper.java ---
    @@ -0,0 +1,28 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.core.fs;
    +
    +public interface AbstractHadoopWrapper {
    --- End diff --
    
    Good catch. I think the interface started its life as a abstract class ;)
    I'll change it.


> Generalize Flink's DistributedFileSystemClass to a Hadoop FileSystem wrapper
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-1266
>                 URL: https://issues.apache.org/jira/browse/FLINK-1266
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>            Priority: Minor
>
> Currently, the Hadoop's DistributedFileSystem class is somewhat hardwired 
> into the Flink DistributedFileSystem class.
> That is actually not necessary because Flink's DistributedFileSystem class is 
> only assuming Hadoop's FileSystem class.
> By generalizing the Flink DFS class, we can easily support other file systems 
> implementing the Hadoop FS class, such as the GoogleHadoopFileSystem, Tachyon 
> and others.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to