Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/269#issuecomment-67166915
Looks good.
Here are some issues that we need to watch out for:
- I think we need to have the ASM dependency as a managed dependency in
the parent pom. There are different parts that use ASM in potentially different
versions (the JAR builder in a pending pull request uses ASM 5 to support
lambdas)
- Does the closure cleaner visit all methods? (I am not familiar enough
with ASM to figure that out from the code)
- Should we add a test where the outer field is accessed not from the
`map()` method itself, but from another method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
