luoyuxia commented on code in PR #1485:
URL: https://github.com/apache/fluss/pull/1485#discussion_r2265764906
##########
fluss-flink/fluss-flink-common/src/main/java/com/alibaba/fluss/flink/tiering/committer/FlussTableLakeSnapshotCommitter.java:
##########
@@ -114,15 +114,19 @@ private CommitLakeTableSnapshotRequest
toCommitLakeTableSnapshotRequest(
pbLakeTableSnapshotInfo.setTableId(flussTableLakeSnapshot.tableId());
pbLakeTableSnapshotInfo.setSnapshotId(flussTableLakeSnapshot.lakeSnapshotId());
- for (Map.Entry<TableBucket, Long> bucketEndOffsetEntry :
+ for (Map.Entry<Tuple2<TableBucket, String>, Long> bucketEndOffsetEntry
:
flussTableLakeSnapshot.logEndOffsets().entrySet()) {
PbLakeTableOffsetForBucket pbLakeTableOffsetForBucket =
pbLakeTableSnapshotInfo.addBucketsReq();
- TableBucket tableBucket = bucketEndOffsetEntry.getKey();
+ TableBucket tableBucket = bucketEndOffsetEntry.getKey().f0;
+ String partitionName = bucketEndOffsetEntry.getKey().f1;
long endOffset = bucketEndOffsetEntry.getValue();
if (tableBucket.getPartitionId() != null) {
pbLakeTableOffsetForBucket.setPartitionId(tableBucket.getPartitionId());
}
+ if (partitionName != null) {
Review Comment:
But it may still happen that partition is not null, but partition name is
null in a old version of tiering service..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
