gyang94 commented on PR #1509: URL: https://github.com/apache/fluss/pull/1509#issuecomment-3182080223
> Hi @gyang94 , > > I suggest we first focus on supporting the RPC and API interfaces for altering **client-side table properties**, such as those under `client.*`, watermark configurations, and computed column settings. These are properties that can be safely updated online without requiring coordination with storage-layer components. > > In contrast, properties under `table.*` are typically **storage-side configurations** that often require dynamic updates across TabletServers or changes to the underlying storage state. For example, flipping `table.datalake.enabled` from `false` to `true` would require not only updating the table config but also creating the corresponding external data lake table upfront. Hi @wuchong , thanks for the comments. I agree. In this PR, I think it is better to focus on the altering API and process, not for altering any specific configs. To keep the update safely, I use a "whitelist"`FlussConfigUtils.ALTERABLE_CONFIG_OPTIONS` to check which property can be updated. This `table.datalake.enabled` is the one that I put into this list for... just enable altering something. It looks not a good choice here. I can modify it to use other safely updated configs. I understand that we need do extra work when changing this config(#431 ). For this kind of configs, I expect they will be added into the "whitelist" one by one after handle extra work when altering them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
