xx789633 commented on code in PR #1565:
URL: https://github.com/apache/fluss/pull/1565#discussion_r2284516500
##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/IcebergTieringTest.java:
##########
@@ -319,22 +358,40 @@ private void createTable(TablePath tablePath, boolean
isPrimaryTable) throws Exc
6, TIMESTAMP_COLUMN_NAME,
Types.TimestampType.withZone())),
identifierFieldIds);
+ PartitionSpec.Builder builder = PartitionSpec.builderFor(schema);
+ if (isPartitionedTable) {
+ builder.identity("c3");
+ }
+
+ PartitionSpec partitionSpec;
+ if (isPrimaryTable) {
+ partitionSpec = builder.bucket("c1", 3).build();
Review Comment:
should we use the defined bucket number rather than hard-code this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
