MehulBatra commented on code in PR #1577:
URL: https://github.com/apache/fluss/pull/1577#discussion_r2296793357
##########
fluss-lake/fluss-lake-iceberg/src/test/java/com/alibaba/fluss/lake/iceberg/testutils/FlinkIcebergTieringTestBase.java:
##########
@@ -219,9 +221,22 @@ protected long createPkTable(TablePath tablePath, int
bucketNum) throws Exceptio
TableDescriptor.builder()
.schema(
Schema.newBuilder()
- .column("a", DataTypes.INT())
- .column("b", DataTypes.STRING())
- .primaryKey("a")
+ .column("f_boolean",
DataTypes.BOOLEAN())
+ .column("f_byte", DataTypes.TINYINT())
+ .column("f_short",
DataTypes.SMALLINT())
+ .column("f_int", DataTypes.INT())
+ .column("f_long", DataTypes.BIGINT())
+ .column("f_float", DataTypes.FLOAT())
+ .column("f_double", DataTypes.DOUBLE())
+ .column("f_string", DataTypes.STRING())
+ .column("f_decimal1",
DataTypes.DECIMAL(5, 2))
+ .column("f_decimal2",
DataTypes.DECIMAL(20, 0))
+ .column("f_timestamp_ltz1",
DataTypes.TIMESTAMP_LTZ(3))
+ .column("f_timestamp_ltz2",
DataTypes.TIMESTAMP_LTZ(6))
+ .column("f_timestamp_ntz1",
DataTypes.TIMESTAMP(3))
+ .column("f_timestamp_ntz2",
DataTypes.TIMESTAMP(6))
+ .column("f_binary",
DataTypes.BINARY(4))
Review Comment:
We should include them aswell as we have them covered in
`FlussDataTypeToIcebergDataType` class, what do you think?
```
.column("f_char", DataTypes.CHAR(4))
.column("f_bytes", DataTypes.BYTES())
.column("f_date", DataTypes.DATE())
.column("f_time", DataTypes.TIME())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
