luoyuxia commented on code in PR #1359:
URL: https://github.com/apache/fluss/pull/1359#discussion_r2320747717
##########
fluss-common/src/main/java/com/alibaba/fluss/config/ConfigOptions.java:
##########
@@ -61,6 +61,12 @@ public class ConfigOptions {
"ch.qos.logback"
};
+ @Internal
+ public static final String[] PARENT_FIRST_HDFS_PATTERNS =
+ new String[] {
+ "hdfs-site", "core-site", "org.apache.hadoop.", "META-INF",
Review Comment:
@beryllw Thanks for the great work!! Let's me have a summary, please correct
me if I'm wrong.
So, It turns out to be:
option1:
Only add `org.apache.hadoop.` to parent first pattern in Fluss code, works
for when Kerberos is not enabled. When Kerberos is enabled, users must add
`core-site.xml` to parent first pattern manually.
option2: Add `org.apache.hadoop.`, `core-site.xml` to parent first pattern
in Fluss code, works whatever Kerberos is enabled or not. But after we
introduce `security` module, we can also remove `core-site.xml` to parent first
pattern.
I perfer option2 since it require users do nothing in Kerberos enabled env.
And I do meet some users are in Kerberos enabled env. @wuchong What do you
think of it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
