luoyuxia commented on code in PR #1587:
URL: https://github.com/apache/fluss/pull/1587#discussion_r2329452136


##########
website/docs/streaming-lakehouse/integrate-data-lakes/lance.md:
##########
@@ -0,0 +1,98 @@
+---
+title: Lance
+sidebar_position: 1

Review Comment:
   use `sidebar_position: 3`
   `sidebar_position: 1` is for paimon, `sidebar_position: 2` is for iceberg 
which will be added.



##########
website/docs/streaming-lakehouse/integrate-data-lakes/lance.md:
##########
@@ -0,0 +1,98 @@
+---

Review Comment:
   ```Currently, Fluss supports [Paimon as Lakehouse 
Storage](http://localhost:3000/docs/streaming-lakehouse/integrate-data-lakes/paimon/),
 more kinds of data lake formats are on the roadmap.```
   We shoud adjust the statement in page `streaming-lakehouse/overview/` since 
lance is supported now.



##########
website/docs/streaming-lakehouse/integrate-data-lakes/lance.md:
##########
@@ -0,0 +1,98 @@
+---
+title: Lance
+sidebar_position: 1
+---
+
+# Lance
+
+[Lance](https://lancedb.github.io/lance/) is a modern table format optimized 
for machine learning and AI applications. 
+To integrate Fluss with Lance, you must enable lakehouse storage and configure 
Lance as the lakehouse storage. For more details, see [Enable Lakehouse 
Storage](maintenance/tiered-storage/lakehouse-storage.md#enable-lakehouse-storage).

Review Comment:
   I'm wondering is it possible to guide how to start the Tiering Service to 
lance. Although it refers to 
(maintenance/tiered-storage/lakehouse-storage.md#enable-lakehouse-storage). But 
it's used Paimon as the example, not every step is suitable to lance. I think 
add an seperate page to guide how to start the Tiering Service to lance is much 
benefit to users



##########
website/docs/streaming-lakehouse/integrate-data-lakes/lance.md:
##########
@@ -0,0 +1,98 @@
+---
+title: Lance
+sidebar_position: 1
+---
+
+# Lance
+
+[Lance](https://lancedb.github.io/lance/) is a modern table format optimized 
for machine learning and AI applications. 
+To integrate Fluss with Lance, you must enable lakehouse storage and configure 
Lance as the lakehouse storage. For more details, see [Enable Lakehouse 
Storage](maintenance/tiered-storage/lakehouse-storage.md#enable-lakehouse-storage).
+
+## Introduction
+
+To configure Lance as the lakehouse storage, you must configure the following 
configurations in `server.yaml`:
+```yaml
+# Lance configuration
+datalake.format: lance
+
+datalake.lance.warehouse: /tmp/lance
+
+# To use S3 as Lance storage backend, you need to specify the following 
properties

Review Comment:
   IIUC, now, only s3 and local filesystem is supported, right? Please add a 
note for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to