wuchong commented on code in PR #1548:
URL: https://github.com/apache/fluss/pull/1548#discussion_r2351660824
##########
fluss-server/src/main/java/org/apache/fluss/server/coordinator/CoordinatorEventProcessor.java:
##########
@@ -456,6 +457,20 @@ private void loadAssignment(
coordinatorContext.putBucketLeaderAndIsr(tableBucket,
leaderAndIsr);
}
}
+
+ // register table/bucket metrics when initialing context.a
Review Comment:
```suggestion
// register table/bucket metrics when initialing context
```
##########
fluss-server/src/main/java/org/apache/fluss/server/replica/Replica.java:
##########
@@ -246,10 +249,36 @@ public Replica(
private void registerMetrics() {
// get root metric in the reference: bucket -> table -> tabletServer
TabletServerMetricGroup serverMetrics =
- bucketMetricGroup.getTableMetricGroup().getServerMetricGroup();
+ ((TableMetricGroup) bucketMetricGroup.getParentMetricGroup())
Review Comment:
This is still very hack. We can introduce a private
`SimpleBucketMetricGroup` in `CoordinatorMetricGroup` like
`SimpleTableMetricGroup`. And expose it as `MetricGroup` for method
`getTableBucketMetricGroup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
