juice928 commented on PR #2537:
URL: https://github.com/apache/fluss/pull/2537#issuecomment-3842967103
👋 Hi, I'm an automated AI code review bot. I ran some checks on this PR and
found **1 point that might be worth attention** (could be false positives,
please use your judgment):
1. <strong>Ensure ListVector registers the correct row count</strong>
-
[Location](https://github.com/apache/fluss/blob/5f17690fc6aed7cc3db3111d66fd393d54fb1830/fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/utils/ArrowDataConverter.java#L140-L144):
`fluss-lake/fluss-lake-lance/src/main/java/org/apache/fluss/lake/lance/utils/ArrowDataConverter.java:L140-L144`
- Impact: The destination vector might appear empty to downstream readers
because `setLastSet` doesn't automatically update the internal `valueCount`.
- Suggestion: Consider using `setValueCount(valueCount)` instead of
`setLastSet` to ensure the vector correctly reflects the amount of data copied.
If you find these suggestions disruptive, you can reply "stop" , and I'll
automatically skip this repository in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
