wuchong commented on code in PR #2569:
URL: https://github.com/apache/fluss/pull/2569#discussion_r2766937466


##########
website/docs/quickstart/flink.md:
##########
@@ -129,16 +166,25 @@ docker compose up -d
 ```
 This command automatically starts all the containers defined in the Docker 
Compose configuration in detached mode.
 
-Run 
+Run
 ```shell
 docker compose ps
 ```
 to check whether all containers are running properly.
 
+4. Create the S3 bucket for Fluss tiered storage. Open the RustFS console at 
http://localhost:9001, login with `rustfsadmin/rustfsadmin`, click **"Create 
Bucket"** in the top left corner, enter `fluss` as the bucket name, and click 
**Create**.
+
+Alternatively, you can use the MinIO client (`mc`) which is compatible with 
RustFS:
+```shell
+docker run --rm --net=host \
+    -e MC_HOST_rustfs=http://rustfsadmin:rustfsadmin@localhost:9000 \
+    minio/mc mb rustfs/fluss

Review Comment:
   Can this bucket be automantically created in the docker compose?



##########
website/docs/quickstart/flink.md:
##########
@@ -72,8 +94,15 @@ services:
         zookeeper.address: zookeeper:2181
         bind.listeners: FLUSS://tablet-server:9123
         data.dir: /tmp/fluss/data
-        remote.data.dir: /tmp/fluss/remote-data
-        kv.snapshot.interval: 0s
+        remote.data.dir: s3://fluss/remote-data
+        s3.endpoint: http://rustfs:9000
+        s3.access-key: rustfsadmin
+        s3.secret-key: rustfsadmin
+        s3.path-style-access: true
+        kv.snapshot.interval: 60s

Review Comment:
   It's great we can remove the hack `kv.snapshot.interval: 0s` :) 



##########
website/docs/quickstart/flink.md:
##########
@@ -72,8 +94,15 @@ services:
         zookeeper.address: zookeeper:2181
         bind.listeners: FLUSS://tablet-server:9123
         data.dir: /tmp/fluss/data
-        remote.data.dir: /tmp/fluss/remote-data
-        kv.snapshot.interval: 0s
+        remote.data.dir: s3://fluss/remote-data
+        s3.endpoint: http://rustfs:9000
+        s3.access-key: rustfsadmin
+        s3.secret-key: rustfsadmin
+        s3.path-style-access: true
+        kv.snapshot.interval: 60s
+    volumes:
+      - ./lib:/tmp/fluss-lib
+    entrypoint: ["sh", "-c", "cp -v /tmp/fluss-lib/fluss-fs-s3-*.jar 
/opt/fluss/lib/ 2>/dev/null || true && exec /docker-entrypoint.sh tabletServer"]

Review Comment:
   ditto



##########
website/docs/quickstart/flink.md:
##########
@@ -43,27 +43,49 @@ export FLINK_VERSION="1.20"
 mkdir lib
 wget -O lib/flink-faker-0.5.3.jar 
https://github.com/knaufk/flink-faker/releases/download/v0.5.3/flink-faker-0.5.3.jar
 wget -O "lib/fluss-flink-${FLINK_VERSION}-$FLUSS_DOCKER_VERSION$.jar" 
"https://repo1.maven.org/maven2/org/apache/fluss/fluss-flink-${FLINK_VERSION}/$FLUSS_DOCKER_VERSION$/fluss-flink-${FLINK_VERSION}-$FLUSS_DOCKER_VERSION$.jar";
+wget -O "lib/fluss-fs-s3-$FLUSS_DOCKER_VERSION$.jar" 
"https://repo1.maven.org/maven2/org/apache/fluss/fluss-fs-s3/$FLUSS_DOCKER_VERSION$/fluss-fs-s3-$FLUSS_DOCKER_VERSION$.jar";
 ```
 
 3. Create a `docker-compose.yml` file with the following content:
 
 ```yaml
 services:
+  #begin RustFS (S3-compatible storage)
+  rustfs:
+    image: rustfs/rustfs:latest
+    ports:
+      - "9000:9000"
+      - "9001:9001"
+    environment:
+      - RUSTFS_ACCESS_KEY=rustfsadmin
+      - RUSTFS_SECRET_KEY=rustfsadmin
+      - RUSTFS_CONSOLE_ENABLE=true
+    volumes:
+      - rustfs-data:/data
+    command: /data
+  #end
   #begin Fluss cluster
   coordinator-server:
     image: apache/fluss:$FLUSS_DOCKER_VERSION$
     command: coordinatorServer
     depends_on:
       - zookeeper
+      - rustfs
     environment:
       - |
         FLUSS_PROPERTIES=
         zookeeper.address: zookeeper:2181
         bind.listeners: FLUSS://coordinator-server:9123
-        remote.data.dir: /tmp/fluss/remote-data
+        remote.data.dir: s3://fluss/remote-data
+        s3.endpoint: http://rustfs:9000
+        s3.access-key: rustfsadmin
+        s3.secret-key: rustfsadmin
+        s3.path-style-access: true
+    volumes:
+      - ./lib:/tmp/fluss-lib
+    entrypoint: ["sh", "-c", "cp -v /tmp/fluss-lib/fluss-fs-s3-*.jar 
/opt/fluss/lib/ 2>/dev/null || true && exec /docker-entrypoint.sh 
coordinatorServer"]

Review Comment:
   We don't need to copy `fluss-fs-s3-*.jar` to fluss/lib, because it has 
already in the default distribution under `fluss/plugin`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to