Copilot commented on code in PR #267: URL: https://github.com/apache/fluss-rust/pull/267#discussion_r2776810405
########## DEVELOPMENT.md: ########## @@ -104,6 +104,15 @@ cargo test --features integration_tests --workspace ``` +### License check (cargo-deny) + +We use [cargo-deny](https://embarkstudios.github.io/cargo-deny/) to ensure all dependency licenses are Apache-compatible. Configuration is in `deny.toml` at the repo root. Review Comment: `DEVELOPMENT.md` claims the cargo-deny configuration is in `deny.toml` at the repo root, but there is no `deny.toml` in the repository. Either add `deny.toml` (with the intended Apache-compatible license policy) or update this text to reflect the actual configuration/location so contributors don’t follow broken instructions. ```suggestion We use [cargo-deny](https://embarkstudios.github.io/cargo-deny/) to ensure all dependency licenses are Apache-compatible. When present, configuration lives in a `deny.toml` file at the repo root and should enforce an Apache-compatible license policy. ``` ########## .github/workflows/ci.yml: ########## @@ -38,6 +38,14 @@ jobs: - name: Check License Header uses: apache/skywalking-eyes/[email protected] + - name: Install cargo-deny + uses: taiki-e/install-action@v2 + with: + tool: [email protected] + + - name: Check dependency licenses (Apache-compatible) + run: cargo deny check licenses Review Comment: CI runs `cargo deny check licenses`, but the PR doesn’t add the `deny.toml` config referenced in the issue/DEVELOPMENT.md. Without an explicit policy file, this may not enforce the intended “Apache-compatible” license allow/deny list (or may behave differently than expected). Add `deny.toml` to the repo (or adjust the workflow+docs to match the chosen approach). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
