Copilot commented on code in PR #268: URL: https://github.com/apache/fluss-rust/pull/268#discussion_r2777486096
########## .github/workflows/release_python.yml: ########## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Publish the fluss Python binding to PyPI. +# Trigger: push tag only (e.g. v0.1.0). +# Pre-release tags (containing '-') publish to TestPyPI; release tags publish to PyPI. +# +# Token auth: set repo variable PYPI_USE_TOKEN_AUTH = 'true' and add secrets PYPI_API_TOKEN / TEST_PYPI_API_TOKEN. +# Trusted Publishing (OIDC): leave PYPI_USE_TOKEN_AUTH unset; do not pass password so the action uses OIDC. + +name: Release Python + +on: + push: + tags: + - "*" + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }} + cancel-in-progress: true + +permissions: + contents: read + +jobs: + sdist: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - name: Install protoc + run: sudo apt-get update && sudo apt-get install -y protobuf-compiler + + - uses: PyO3/maturin-action@v1 + with: + working-directory: bindings/python + command: sdist + args: -o dist + + - name: Upload sdist + uses: actions/upload-artifact@v4 + with: + name: wheels-sdist + path: bindings/python/dist + + wheels: + runs-on: ${{ matrix.os }} + strategy: + matrix: + include: + - { os: windows-latest } + - { os: macos-15-intel, target: "x86_64-apple-darwin" } + - { os: macos-15, target: "aarch64-apple-darwin" } + - { os: ubuntu-latest, target: "x86_64" } + - { os: ubuntu-latest, target: "aarch64", manylinux: "manylinux_2_28" } + steps: + - uses: actions/checkout@v4 + + - name: Install protoc (Linux) + if: runner.os == 'Linux' + run: sudo apt-get update && sudo apt-get install -y protobuf-compiler + + - name: Install protoc (macOS) + if: runner.os == 'macOS' + run: brew install protobuf + + - name: Install protoc (Windows) + if: runner.os == 'Windows' + run: choco install protobuf -y + shell: pwsh + + - uses: PyO3/maturin-action@v1 + with: + working-directory: bindings/python + target: ${{ matrix.target }} + command: build + args: --release -o dist -i python3.11 + manylinux: ${{ matrix.manylinux || 'auto' }} + - uses: PyO3/maturin-action@v1 + with: + working-directory: bindings/python + target: ${{ matrix.target }} + command: build + args: --release -o dist -i python3.12 + manylinux: ${{ matrix.manylinux || 'auto' }} Review Comment: Wheel builds are only generated for Python 3.11 and 3.12, but `pyproject.toml` declares support for Python 3.9+ (and includes 3.9/3.10 classifiers). With the current setup, 3.9/3.10 users will fall back to building from sdist (requiring a Rust toolchain, protoc, etc.). Consider adding wheel builds for 3.9 and 3.10 or narrowing `requires-python`/classifiers to match what you ship. ########## scripts/constants.py: ########## @@ -0,0 +1,44 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import tomllib +from pathlib import Path + +ROOT_DIR = Path(__file__).resolve().parent.parent + + +def list_packages(): + """Package directories from [workspace].members in root Cargo.toml, plus workspace root. + Each gets a DEPENDENCIES.rust.tsv. Avoids scanning target/, .git/, etc. + """ + root_cargo = ROOT_DIR / "Cargo.toml" + if not root_cargo.exists(): + return ["."] + with open(root_cargo, "rb") as f: + data = tomllib.load(f) Review Comment: `tomllib` is only available in Python 3.11+. Since the release docs invoke this script via `python3`, this will fail on Python 3.9/3.10 (which are still commonly installed and also listed as supported for the Python bindings). Consider using a `tomli` fallback for <3.11 or explicitly documenting/enforcing a Python >=3.11 requirement for the release tooling. ########## docs/creating-a-release.md: ########## @@ -0,0 +1,452 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> + +# Creating a Fluss Rust Client Release + +This document describes in detail how to create a release of the **Fluss clients** (fluss-rust, fluss-python, fluss-cpp) from the [fluss-rust](https://github.com/apache/fluss-rust) repository. It is based on the [Creating a Fluss Release](https://fluss.apache.org/community/how-to-release/creating-a-fluss-release/) guide of the Apache Fluss project and the [release guide of Apache OpenDAL](https://nightlies.apache.org/opendal/opendal-docs-stable/community/release/); releases are source archives plus CI-published crates.io and PyPI. + +Publishing software has legal consequences. This guide complements the foundation-wide [Product Release Policy](https://www.apache.org/legal/release-policy.html) and [Release Distribution Policy](https://infra.apache.org/release-distribution.html). + +## Overview + + + +The release process consists of: + +1. [Decide to release](#decide-to-release) +2. [Prepare for the release](#prepare-for-the-release) +3. [Build a release candidate](#build-a-release-candidate) +4. [Vote on the release candidate](#vote-on-the-release-candidate) +5. [If necessary, fix any issues and go back to step 3](#fix-any-issues) +6. [Finalize the release](#finalize-the-release) +7. [Promote the release](#promote-the-release) + +## Decide to release + +Deciding to release and selecting a Release Manager is the first step. This is a consensus-based decision of the community. + +Anybody can propose a release (e.g. on the dev mailing list), giving a short rationale and nominating a committer as Release Manager (including themselves). Any objections should be resolved by consensus before starting. + +**Checklist to proceed** + +- [ ] Community agrees to release +- [ ] A Release Manager is selected + +## Prepare for the release + +### 0. One-time Release Manager setup + +Before your first release, perform one-time configuration. See **[Release Manager Preparation](https://fluss.apache.org/community/how-to-release/release-manager-preparation/)** (GPG key, etc.). For fluss-rust you do **not** need Nexus/Maven; you only need GPG for signing the source archive and (optionally) git signing. + +**Checklist (one-time)** + +- [ ] GPG key set up and published to [KEYS](https://downloads.apache.org/incubator/fluss/KEYS) or Apache account +- [ ] Git configured to use your GPG key for signing tags + +### 1. Install Rust (and optional: just) + +The release script (`just release` or `./scripts/release.sh`) uses `git archive` and `gpg`; building or verifying the project locally requires **Rust**. Install the [Rust toolchain](https://rustup.rs/) (the version should match [rust-toolchain.toml](https://github.com/apache/fluss-rust/blob/main/rust-toolchain.toml) in the repo). + +```bash +rustc --version +cargo --version +``` + +To use `just release`, install [just](https://github.com/casey/just) (e.g. `cargo install just` or your system package manager). If you prefer not to use just, run `./scripts/release.sh $RELEASE_VERSION` instead. + +### 2. Optional: Create a new Milestone in GitHub + +If the project uses GitHub milestones for release tracking, create a new milestone for the **next** version (e.g. `v0.2` if you are releasing `0.1.x`). This helps contributors target issues to the correct release. + +### 3. Optional: Triage release-blocking issues + +Check open issues that might block the release. Resolve, defer to the next milestone, or mark as blocker and do not proceed until they are fixed. + +### 4. Clone fluss-rust into a fresh workspace + +Use a clean clone to avoid local changes affecting the release. + +```bash +git clone https://github.com/apache/fluss-rust.git +cd fluss-rust +``` + +### 5. Set up environment variables + +Set these once and use them in all following commands. (Bash syntax.) + +```bash +export RELEASE_VERSION="0.1.0" +export RELEASE_TAG="v${RELEASE_VERSION}" +export SVN_RELEASE_DIR="fluss-rust-${RELEASE_VERSION}" +# Only set if there is a previous release (for compare link in DISCUSS / release notes) +export LAST_VERSION="0.0.9" +export NEXT_VERSION="0.2.0" +``` + +For the **first release** there is no previous version; leave `LAST_VERSION` unset or omit it when using the compare link in the DISCUSS thread and release notes. + +### 6. Generate dependencies list + +[ASF release policy](https://www.apache.org/legal/release-policy.html) requires that every release comply with [ASF licensing policy](https://www.apache.org/legal/resolved.html) and that an **audit be performed before a full release**. Generating and committing a dependency list (and using cargo-deny) documents third-party components and supports this requirement. + +Do this on `main` **before** creating the release branch. Then both the release branch (when created from `main`) and `main` will have the same dependency list. + +1. Download and set up [cargo-deny](https://embarkstudios.github.io/cargo-deny/cli/index.html) (see cargo-deny docs). +2. Run the script to update the dependency list, then commit on `main`: + +```bash +git checkout main +git pull +python3 scripts/dependencies.py generate +git add **/DEPENDENCIES*.tsv +# Bash: run shopt -s globstar first so ** matches subdirs +git commit -m "chore: update dependency list for release ${RELEASE_VERSION}" +git push origin main +``` + +To only check licenses (no file update): `python3 scripts/dependencies.py check`. + +### 7. Optional: Start a [DISCUSS] thread + +On [Fluss Discussions](https://github.com/apache/fluss-rust/discussions) or the dev list: + +- **Subject:** `[DISCUSS] Release Apache Fluss clients (fluss-rust, fluss-python, fluss-cpp) $RELEASE_VERSION` +- **Body:** Short rationale; if there is a previous release, add compare link: `https://github.com/apache/fluss-rust/compare/v${LAST_VERSION}...main`. Ask for comments. + +### 8. Create a release branch + +From `main`, create a release branch. All release artifacts will be built from this branch. The tag (RC or release) is created later when building the release candidate. + +```bash +git checkout main +git pull +git checkout -b release-${RELEASE_VERSION} +git push origin release-${RELEASE_VERSION} +``` + +Do **not** create or push the release/RC tag yet; that happens in [Build a release candidate](#build-a-release-candidate) after the source artifacts are staged. + +### 9. Bump version on main for the next development cycle + +So that `main` moves to the next version immediately after the release branch is cut, run the bump script and commit: + +```bash +git checkout main +git pull + +./scripts/bump-version.sh $RELEASE_VERSION $NEXT_VERSION + +git add Cargo.toml +git commit -m "Bump version to ${NEXT_VERSION}" +git push origin main +``` + +The script updates the root `Cargo.toml` ([workspace.package] and [workspace.dependencies] fluss-rs). crates/fluss and bindings inherit `version` from the workspace. + +### 10. Optional: Create PRs for release blog and download page + +You can open a pull request in the **Apache Fluss** repository for the release blog (announcement). If the project website has a download page, also create a PR to add the new version there. **Do not merge these PRs until the release is finalized.** + +--- + +**Checklist to proceed to the next step** + +- [ ] Rust (and optionally just) installed and on PATH +- [ ] No release-blocking issues (or triaged) +- [ ] Environment variables set +- [ ] Release branch created and pushed +- [ ] Main branch bumped to `NEXT_VERSION` and pushed +- [ ] Dependencies list generated and committed on main +- [ ] (Optional) DISCUSS thread and/or tracking issue created +- [ ] (Optional) PRs for blog and download page created but not merged + +## Build a release candidate + +Each release candidate is built from the release branch, signed, and staged to the dev area of dist.apache.org. If an RC fails the vote, fix issues and repeat this section with an incremented `RC_NUM` (see [Fix any issues](#fix-any-issues)). + +### 1. Set RC environment variables + +Set these when building a **release candidate**. Start with `RC_NUM=1`; if the vote fails and you build a new candidate, increment to `2`, then `3`, etc. + +```bash +export RC_NUM="1" +export RC_TAG="v${RELEASE_VERSION}-rc${RC_NUM}" +export SVN_RC_DIR="fluss-rust-${RELEASE_VERSION}-rc${RC_NUM}" +``` + +For a **direct release** (no RC), skip these and use `RELEASE_TAG` and `SVN_RELEASE_DIR` from the Prepare step instead. + +### 2. Check out the release branch and create the tag + +Check out the release branch at the commit you want to release, create the signed tag, then push it. Use `RC_TAG` for a release candidate or `RELEASE_TAG` for a direct release. Pushing the tag triggers GitHub Actions (for an RC tag, fluss-python is published to TestPyPI). + +```bash +git checkout release-${RELEASE_VERSION} +git pull +git tag -s $RC_TAG -m "${RC_TAG}" +git push origin $RC_TAG +``` + +Check CI: [Actions](https://github.com/apache/fluss-rust/actions) (Release Rust, Release Python). + +### 3. Create source release artifacts + +From the repository root (on the release branch, at the commit you tagged): + +```bash +just release $RELEASE_VERSION +# Or: ./scripts/release.sh $RELEASE_VERSION +``` + +This creates under `dist/`: + +- `fluss-rust-${RELEASE_VERSION}.tar.gz` +- `fluss-rust-${RELEASE_VERSION}.tar.gz.sha512` +- `fluss-rust-${RELEASE_VERSION}.tar.gz.asc` + +Verify with: `gpg --verify dist/fluss-rust-${RELEASE_VERSION}.tar.gz.asc dist/fluss-rust-${RELEASE_VERSION}.tar.gz` + +### 4. Stage artifacts to SVN (dist.apache.org dev) + +From the **fluss-rust** repo root, check out the Fluss dev area and add the release artifacts. + +```bash +svn checkout https://dist.apache.org/repos/dist/dev/incubator/fluss fluss-dist-dev --depth=immediates +cd fluss-dist-dev +mkdir $SVN_RC_DIR +cp ../dist/fluss-rust-${RELEASE_VERSION}.* $SVN_RC_DIR/ +svn add $SVN_RC_DIR +svn status +svn commit -m "Add fluss-rust ${RELEASE_VERSION} RC${RC_NUM}" +``` + +Verify: [https://dist.apache.org/repos/dist/dev/incubator/fluss/](https://dist.apache.org/repos/dist/dev/incubator/fluss/) + +--- + +**Checklist to proceed to the next step** + +- [ ] Source distribution built and signed under `dist/` +- [ ] Artifacts staged to [dist.apache.org dev](https://dist.apache.org/repos/dist/dev/incubator/fluss/) under `$SVN_RC_DIR` +- [ ] RC (or release) tag pushed to GitHub +- [ ] CI for Release Rust / Release Python succeeded + +## Vote on the release candidate + +Share the release candidate for community review. If the project is in incubation, a [two-phase vote](https://incubator.apache.org/cookbook/#two_phase_vote_on_podling_releases) (Fluss community then Incubator PMC) may be required; otherwise one community vote is enough. + +### Fluss community vote + +Start the vote on the dev@ mailing list. + +**Subject:** `[VOTE] Release Apache Fluss clients (fluss-rust, fluss-python, fluss-cpp) ${RELEASE_VERSION} (RC${RC_NUM})` + +**Body template:** + +``` +Hi everyone, + +Please review and vote on release candidate #${RC_NUM} for Apache Fluss clients (fluss-rust, fluss-python, fluss-cpp) ${RELEASE_VERSION}. + +[ ] +1 Approve the release +[ ] +0 No opinion +[ ] -1 Do not approve (please provide specific comments) + +The release candidate (source distribution) is available at: +* https://dist.apache.org/repos/dist/dev/incubator/fluss/$SVN_RC_DIR/ + +KEYS for signature verification: +* https://downloads.apache.org/incubator/fluss/KEYS + +Git tag: +* https://github.com/apache/fluss-rust/releases/tag/$RC_TAG + +PyPI (release) / TestPyPI (RC): +* https://pypi.org/project/pyfluss/ +* https://test.pypi.org/project/pyfluss/ + +Please download, verify, and test. Verification steps are in the project docs (todo: add how to verify release). + +The vote will be open for at least 72 hours. It is adopted by majority approval with at least 3 PPMC affirmative votes (or as per project policy). + +Thanks, +Release Manager +``` + +If issues are found, cancel the vote and go to [Fix any issues](#fix-any-issues). If the vote passes, close it and tally the result in a follow-up: + +**Subject:** `[RESULT][VOTE] Release Apache Fluss clients ${RELEASE_VERSION} (RC${RC_NUM})` + +**Body:** Summarize binding and non-binding votes and link to the vote thread. + +### Incubator PMC vote (if applicable) + +If the project is in incubation, start a vote on [email protected] after the Fluss community vote passes. Use the same structure: link to the community vote thread, release candidate URL, KEYS, tag, and ask IPMC to vote within 72 hours. Then send the result to the same list. + +--- + +**Checklist to proceed to finalization** + +- [ ] Community vote passed (at least 3 binding +1, more +1 than -1) +- [ ] (If incubating) Incubator PMC vote passed + +## Fix any issues + +If the vote revealed issues: + +1. Fix them on `main` (or the release branch) via normal PRs; cherry-pick fixes into the release branch as needed. +2. Remove the old RC from dist.apache.org dev (optional but recommended): + +```bash +svn checkout https://dist.apache.org/repos/dist/dev/incubator/fluss fluss-dist-dev --depth=immediates +cd fluss-dist-dev +svn remove $SVN_RC_DIR +svn commit -m "Remove fluss-rust ${RELEASE_VERSION} RC${RC_NUM} (superseded)" +``` + +3. Increment `RC_NUM` (e.g. set `RC_NUM="2"`), recreate `RC_TAG` and `SVN_RC_DIR`, then go back to [Build a release candidate](#build-a-release-candidate) and repeat until a candidate is approved. + +**Checklist** + +- [ ] Issues resolved and changes merged/cherry-picked to the release branch +- [ ] New RC built and voted on (or same RC re-voted if only minor fixes) + +## Finalize the release + +Once a release candidate has been approved, finalize the release. + +### 1. Push the release git tag (if the vote was on an RC) + +If the community voted on an RC tag, create and push the formal release tag so CI publishes to crates.io and PyPI: + +```bash +git checkout $RC_TAG +git tag -s $RELEASE_TAG -m "Release fluss-rust, fluss-python, fluss-cpp ${RELEASE_VERSION}" +git push origin $RELEASE_TAG +``` + +### 2. Deploy source artifacts to the release repository + +Move the staged artifacts from dev to release: + +```bash +svn mv -m "Release fluss-rust ${RELEASE_VERSION}" \ + https://dist.apache.org/repos/dist/dev/incubator/fluss/$SVN_RC_DIR \ + https://dist.apache.org/repos/dist/release/incubator/fluss/$SVN_RELEASE_DIR +``` + +(Only PPMC members may have write access to the release repository; if you get permission errors, ask on the mailing list.) + +### 3. Remove old RC(s) from dev (optional) + +Clean up the dev area so only the current RC or the moved release remains: + +```bash +cd fluss-dist-dev +svn remove $SVN_RC_DIR +svn commit -m "Remove RC after release fluss-rust ${RELEASE_VERSION}" +``` + +### 4. Verify language artifacts + +- **fluss-rust:** [crates.io/crates/fluss-rs](https://crates.io/crates/fluss-rs) shows version `$RELEASE_VERSION` +- **fluss-python:** [PyPI – pyfluss](https://pypi.org/project/pyfluss/) shows version `$RELEASE_VERSION` +- **fluss-cpp:** Distributed via the source archive; no separate registry + +### 5. Create GitHub Release + +1. Go to [Releases → New release](https://github.com/apache/fluss-rust/releases/new). +2. Choose tag `$RELEASE_TAG`. +3. Set the target to the release branch `release-${RELEASE_VERSION}` (i.e., the branch/commit used to create `$RELEASE_TAG`). +4. Click **Generate release notes**, then add: notable changes, breaking changes (if any) from component upgrade docs, **official download link** (source archive and verification), and install instructions for fluss-rust, fluss-python, fluss-cpp. + - **Download link:** `https://downloads.apache.org/incubator/fluss/fluss-rust-${RELEASE_VERSION}/` (or the project download page). In the release description, include checksums and GPG verification steps. +5. Click **Publish release**. + +### 6. Update CHANGELOG.md on main + +Add an entry for `$RELEASE_VERSION` with the list of changes (use [Generate Release Note](generate-release-note.md) from the release tag). Commit and push to `main`. + +--- + +**Checklist to proceed to promotion** + +- [ ] Release tag pushed; CI published to crates.io and PyPI +- [ ] Source artifacts in [dist release](https://dist.apache.org/repos/dist/release/incubator/fluss/) +- [ ] GitHub Release created +- [ ] CHANGELOG.md updated on main + +## Promote the release + +### Merge website PRs + +Merge the pull requests for the release blog and download page that were created in [Prepare for the release](#9-optional-create-prs-for-release-blog-and-download-page). Review Comment: This internal link target appears to be off by one: the referenced heading is "### 10. Optional: Create PRs for release blog and download page", so `#9-optional-...` likely won’t resolve on GitHub. Update the anchor to match the actual heading so the link works. ```suggestion Merge the pull requests for the release blog and download page that were created in [Prepare for the release](#10-optional-create-prs-for-release-blog-and-download-page). ``` ########## scripts/bump-version.sh: ########## @@ -0,0 +1,54 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to you under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +# Bump version in root Cargo.toml ([workspace.package] and [workspace.dependencies] fluss-rs). +# Run from repo root. Use after cutting a release branch so main is set to the next version. +# +# Usage: ./scripts/bump-version.sh <current_version> <next_version> +# e.g. ./scripts/bump-version.sh 0.1.0 0.1.1 +# Or with env vars: ./scripts/bump-version.sh $RELEASE_VERSION $NEXT_VERSION + +set -e + +if [ -z "$1" ] || [ -z "$2" ]; then + echo "Usage: $0 <current_version> <next_version>" + echo " e.g. $0 0.1.0 0.1.1" + exit 1 +fi + +FROM_VERSION="$1" +TO_VERSION="$2" + +REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" +cd "$REPO_ROOT" + +if [ ! -f Cargo.toml ]; then + echo "Cargo.toml not found. Run from repo root." + exit 1 +fi + +# Replace version = "X.Y.Z" with version = "TO_VERSION" (all occurrences in root Cargo.toml) +case "$(uname -s)" in + Darwin) + sed -i '' "s/version = \"${FROM_VERSION}\"/version = \"${TO_VERSION}\"/g" Cargo.toml + ;; + *) + sed -i "s/version = \"${FROM_VERSION}\"/version = \"${TO_VERSION}\"/g" Cargo.toml + ;; +esac + Review Comment: The header comment says this bumps only `[workspace.package]` and the `fluss-rs` entry under `[workspace.dependencies]`, but the `sed` replacement updates *every* `version = "${FROM_VERSION}"` occurrence in the root `Cargo.toml`. This can unintentionally bump unrelated dependency versions if they happen to match `FROM_VERSION`. Consider scoping the replacement to the intended sections/keys (or using a TOML-aware edit) and failing if the expected fields weren’t updated. ```suggestion # Replace version in [workspace.package] and fluss-rs under [workspace.dependencies] only. TMP_CARGO_TOML="$(mktemp "${TMPDIR:-/tmp}/cargo.toml.XXXXXX")" if ! awk -v from="$FROM_VERSION" -v to="$TO_VERSION" ' BEGIN { in_ws_package = 0; in_ws_deps = 0; pkg_version_updated = 0; fluss_version_updated = 0; } /^\[workspace\.package\]/ { in_ws_package = 1; in_ws_deps = 0; } /^\[workspace\.dependencies\]/ { in_ws_package = 0; in_ws_deps = 1; } /^\[/ && !/^\[workspace\.(package|dependencies)\]/ { in_ws_package = 0; in_ws_deps = 0; } { if (in_ws_package && $1 == "version" && $2 == "=") { gsub("\"" from "\"", "\"" to "\""); if ($0 ~ "version[[:space:]]*=[[:space:]]*\"" to "\"") { pkg_version_updated = 1; } } else if (in_ws_deps && $1 == "fluss-rs" && $2 == "=") { gsub("version[[:space:]]*=[[:space:]]*\"" from "\"", "version = \"" to "\""); if ($0 ~ "version[[:space:]]*=[[:space:]]*\"" to "\"") { fluss_version_updated = 1; } } print; } END { if (!pkg_version_updated) { printf "Error: did not update [workspace.package] version from %s to %s\n", from, to > "/dev/stderr"; exit 1; } if (!fluss_version_updated) { printf "Error: did not update fluss-rs version under [workspace.dependencies] from %s to %s\n", from, to > "/dev/stderr"; exit 1; } } ' Cargo.toml > "$TMP_CARGO_TOML"; then rm -f "$TMP_CARGO_TOML" exit 1 fi mv "$TMP_CARGO_TOML" Cargo.toml ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
