Copilot commented on code in PR #277:
URL: https://github.com/apache/fluss-rust/pull/277#discussion_r2778272052
##########
bindings/python/fluss/__init__.pyi:
##########
@@ -420,6 +420,14 @@ class LogScanner:
start_offset: The offset to start reading from (use
EARLIEST_OFFSET for beginning)
"""
...
+ def unsubscribe_partition(self, partition_id: int, bucket_id: int) -> None:
+ """Unsubscribe from a specific partition bucket (partitioned tables
only).
+
+ Args:
+ partition_id: The partition ID to unsubscribe from
Review Comment:
The docstring for `partition_id` here is a bit ambiguous compared to
`subscribe_partition` above (which says it comes from
`PartitionInfo.partition_id`). Consider using the same phrasing for consistency
and clarity.
```suggestion
partition_id: The partition ID (from PartitionInfo.partition_id)
```
##########
bindings/python/src/table.rs:
##########
@@ -1657,6 +1657,23 @@ impl LogScanner {
})
}
+ /// Unsubscribe from a specific partition bucket (partitioned tables only).
+ ///
+ /// Args:
+ /// partition_id: The partition ID to unsubscribe from
Review Comment:
Docstring is slightly inconsistent with `subscribe_partition`: it doesn’t
indicate that `partition_id` should come from `PartitionInfo.partition_id`.
Consider mirroring the `subscribe_partition` wording to make the expected
identifier unambiguous.
```suggestion
/// partition_id: The partition ID (from PartitionInfo.partition_id)
to unsubscribe from
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
