fresh-borzoni commented on code in PR #265:
URL: https://github.com/apache/fluss-rust/pull/265#discussion_r2778394442
##########
bindings/cpp/include/fluss.hpp:
##########
@@ -182,7 +187,14 @@ struct Schema {
public:
Builder& AddColumn(std::string name, DataType type,
std::string comment = "") {
- columns_.push_back({std::move(name), type, std::move(comment)});
+ columns_.push_back({std::move(name), type, std::move(comment), 0,
0});
+ return *this;
+ }
+
+ Builder& AddDecimalColumn(std::string name, int32_t precision, int32_t
scale,
Review Comment:
Good suggestion 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
