wuchong commented on code in PR #2545:
URL: https://github.com/apache/fluss/pull/2545#discussion_r2782263448
##########
fluss-flink/fluss-flink-common/src/test/java/org/apache/fluss/flink/sink/writer/undo/UndoRecoveryCoordinatorITCase.java:
##########
@@ -374,25 +430,11 @@ void testPartialUpdateMultiBucketComprehensiveRecovery()
throws Exception {
// Phase 3: Perform undo recovery
Map<TableBucket, UndoOffsets> offsetRanges =
buildUndoOffsets(checkpointOffsets, tablePath, admin);
- new UndoRecoveryCoordinator(table, targetColumns)
- .performUndoRecovery(offsetRanges, 0, 1);
+ new UndoRecoveryManager(table,
targetColumns).performUndoRecovery(offsetRanges, 0, 1);
// Phase 4: Verify results (parallel lookup)
List<CompletableFuture<Void>> verifyFutures = new ArrayList<>();
- for (int id : zeroOffsetBucketKeysAfterCheckpoint) {
- final int keyId = id;
- verifyFutures.add(
- lookuper.lookup(row(keyId))
- .thenAccept(
- r ->
- assertThat(r.getSingletonRow())
- .as(
- "Zero-offset
bucket key %d should be deleted",
- keyId)
- .isNull()));
- }
Review Comment:
I think we still need to check the `zeroOffsetBucketKeysAfterCheckpoint`
related rows after restoring. Could you add this test back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
