Prajwal-banakar commented on code in PR #411:
URL: https://github.com/apache/fluss-rust/pull/411#discussion_r2879031424
##########
crates/fluss/src/client/table/lookup.rs:
##########
@@ -85,6 +88,35 @@ impl LookupResult {
.map(|bytes| CompactedRow::from_bytes(&self.row_type,
&bytes[SCHEMA_ID_LENGTH..]))
.collect()
}
+ /// Converts all rows in this result into an Arrow [`RecordBatch`].
+ ///
+ /// This is useful for integration with DataFusion or other Arrow-based
tools.
+ ///
+ /// # Returns
+ /// - `Ok(RecordBatch)` - All rows in columnar Arrow format. Returns an
empty
+ /// batch (with the correct schema) if the result set is empty.
+ /// - `Err(Error)` - If the conversion fails.
+ pub fn to_record_batch(&self) -> Result<RecordBatch> {
Review Comment:
Could you clarify what you'd like here? The core to_record_batch() method is
available on LookupResult. For Python, we could add a lookup_arrow() method on
Lookuper that returns a PyArrow RecordBatch — but I wanted to confirm the
expected API shape before adding it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
