[ https://issues.apache.org/jira/browse/GEODE-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085922#comment-16085922 ]
ASF GitHub Bot commented on GEODE-3051: --------------------------------------- Github user WireBaron commented on the issue: https://github.com/apache/geode/pull/631 Isn't it the same code handling the SSL handshake for both protocols right now? If it's a different code path, then we should probably add a new test for it. On Thu, Jul 13, 2017 at 8:37 AM, galen-pivotal <notificati...@github.com> wrote: > *@galen-pivotal* approved this pull request. > > It looks like CacheServerSSLConnectionDUnitTest.testNonSSLClient tests > that a client using the old client protocol gets an SSL exception. Do you > think it's worth making a test for the new protocol as well? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/geode/pull/631#pullrequestreview-49818299>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AQGwNsVsxyM0gKTQY25WiKBFDqHxrrv2ks5sNjmngaJpZM4OWXjN> > . > > Removing obsolete SSL handling in `AcceptorImpl.accept` catch block > ------------------------------------------------------------------- > > Key: GEODE-3051 > URL: https://issues.apache.org/jira/browse/GEODE-3051 > Project: Geode > Issue Type: Improvement > Components: client/server > Affects Versions: 1.1.1 > Reporter: Udo Kohlmeyer > Assignee: Galen O'Sullivan > > SSL handshake is now done in a separate thread and will never reach the > handler code which is being removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)