[
https://issues.apache.org/jira/browse/GEODE-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090742#comment-16090742
]
ASF GitHub Bot commented on GEODE-3112:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/639
GEODE-3112: Fixing improper ordering of client timeout setting
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-3112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/639.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #639
----
commit 4cf98a4605c17f8c08bc878df2db99fb1d194b6e
Author: David Anuta <david.r.an...@gmail.com>
Date: 2017-07-17T22:25:35Z
GEODE-3112: Fixing improper ordering of client timeout setting
----
> CI failure:
> ClientFunctionTimeoutRegressionTest.testExecuteFunctionReadsDefaultTimeout
> --------------------------------------------------------------------------------------
>
> Key: GEODE-3112
> URL: https://issues.apache.org/jira/browse/GEODE-3112
> Project: Geode
> Issue Type: Bug
> Components: functions
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Shelley Lynn Hughes-Godfrey
> Assignee: David Anuta
>
> {noformat}
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest >
> testExecuteFunctionReadsDefaultTimeout(false,6000,server) [3] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest$$Lambda$21/1996321698.run
> in VM 1 running on Host 11375a95c724 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:377)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:347)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:292)
> at
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest.testExecuteFunctionReadsDefaultTimeout(ClientFunctionTimeoutRegressionTest.java:109)
> Caused by:
> org.junit.ComparisonFailure: [Server did not read
> client_function_timeout from client.] expected:<[tru]e> but was:<[fals]e>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest.executeFunction(ClientFunctionTimeoutRegressionTest.java:179)
> at
> org.apache.geode.internal.cache.execute.ClientFunctionTimeoutRegressionTest.lambda$testExecuteFunctionReadsDefaultTimeout$a0075c0$1(ClientFunctionTimeoutRegressionTest.java:109)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
