[
https://issues.apache.org/jira/browse/GEODE-3255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107739#comment-16107739
]
ASF GitHub Bot commented on GEODE-3255:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/671
GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests
[View the JIRA ticket
here.](https://issues.apache.org/jira/browse/GEODE-3255)
`CreateAlterDestroyRegionCommands` was a large class that contained
multiple commands. Each command was refactored into a separate class, and the
methods shared by the commands were refactored into a new and appropriately
named class of their own. Tests related to `CreateAlterDestroyRegionCommands`
were also refactored.
**Testing status: Precheckin completed successfully**
- [x] JIRA ticket referenced
- [x] PR rebased
- [x] Single, squashed commit
- [x] `gradlew build` runs cleanly
- [x] Tests updated
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3255
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/671.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #671
----
commit 8a0e27fd3bf44cb63871b8b3b226800a845e0e4c
Author: YehEmily <[email protected]>
Date: 2017-07-28T21:23:25Z
GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests
----
> Refactor CreateAlterDestroyRegionCommands
> -----------------------------------------
>
> Key: GEODE-3255
> URL: https://issues.apache.org/jira/browse/GEODE-3255
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{CreateAlterDestroyRegionCommands.java}} is a large class that contains
> multiple commands. Each command should be refactored into a separate class,
> and the methods shared by the commands should be refactored into a new and
> appropriately named class of their own.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
