[ https://issues.apache.org/jira/browse/GEODE-2886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111440#comment-16111440 ]
ASF GitHub Bot commented on GEODE-2886: --------------------------------------- Github user jhuynh1 commented on a diff in the pull request: https://github.com/apache/geode/pull/609#discussion_r130952081 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/WaitUntilFlushedFunction.java --- @@ -85,8 +72,10 @@ public void execute(FunctionContext context) { } } else { - throw new IllegalArgumentException( + IllegalStateException illegalStateException = new IllegalStateException( "The AEQ does not exist for the index " + indexName + " region " + region.getFullPath()); + logger.error(illegalStateException.getMessage()); --- End diff -- I still think we should just throw the exception here. The executing side will either get a true or false anyways and the exception never actually gets propagated to the user. > The WaitUntilFlushedFunction throws an IllegalArgumentException instead of an > IllegalStateException > --------------------------------------------------------------------------------------------------- > > Key: GEODE-2886 > URL: https://issues.apache.org/jira/browse/GEODE-2886 > Project: Geode > Issue Type: Bug > Components: lucene > Reporter: Barry Oglesby > Assignee: Amey Barve > > When the AEQ doesn't exist, the WaitUntilFlushedFunction throws an > IllegalArgumentException like: > {noformat} > Caused by: java.lang.IllegalArgumentException: The AEQ does not exist for the > index xxx region /yyy > at > org.apache.geode.cache.lucene.internal.distributed.WaitUntilFlushedFunction.execute(WaitUntilFlushedFunction.java:89) > at > org.apache.geode.internal.cache.execute.AbstractExecution.executeFunctionLocally(AbstractExecution.java:333) > {noformat} > The arguments are actually fine so should it instead throw an > IllegalStateException? -- This message was sent by Atlassian JIRA (v6.4.14#64029)