[ 
https://issues.apache.org/jira/browse/GEODE-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116973#comment-16116973
 ] 

ASF GitHub Bot commented on GEODE-3258:
---------------------------------------

Github user pdxrunner commented on the issue:

    https://github.com/apache/geode/pull/687
  
    I'll go ahead and review your command refactorings in this PR, keeping in 
mind that the test will be dealt with under the other JIRA. I agree with not 
changing those two DUnit tests at this time. 


> Refactor DiskStoreCommands
> --------------------------
>
>                 Key: GEODE-3258
>                 URL: https://issues.apache.org/jira/browse/GEODE-3258
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{DiskStoreCommands.java}} is a large class that contains multiple commands. 
> Each command should be refactored into a separate class, and the methods 
> shared by the commands should be refactored into a new and appropriately 
> named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to