[ 
https://issues.apache.org/jira/browse/GEODE-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117463#comment-16117463
 ] 

ASF GitHub Bot commented on GEODE-3265:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/696

    GEODE-3265: Refactoring MiscellaneousCommands

    [View the JIRA ticket 
here.](https://issues.apache.org/jira/browse/GEODE-3265)
    
    `MiscellaneousCommands` was a huge class that contained a large number of 
commands. These commands have been split into their own individual command 
classes.
    
    **TESTING STATUS: Precheckin in progress**
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Initial commit is single and squashed
    
    - [x] `gradlew build` runs cleanly
    
    - [ ] Unit tests will be updated with 
[GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3265

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/696.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #696
    
----
commit f130cf3999de22164f405664a29a74d1e8838bba
Author: YehEmily <[email protected]>
Date:   2017-08-07T22:37:23Z

    GEODE-3265: Refactoring MiscellaneousCommands

----


> Refactor MiscellaneousCommands
> ------------------------------
>
>                 Key: GEODE-3265
>                 URL: https://issues.apache.org/jira/browse/GEODE-3265
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>
> {{MiscellaneousCommands.java}} is a large class that contains multiple 
> commands. Each command should be refactored into a separate class, and the 
> methods shared by the commands should be refactored into a new and 
> appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to