[
https://issues.apache.org/jira/browse/GEODE-3416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120666#comment-16120666
]
ASF GitHub Bot commented on GEODE-3416:
---------------------------------------
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/702
GEODE-3416: Reduce synchronization blockages in SocketCloser.
Remove synchronization blocks around HashMap. Replace that implementation
with simpler ThreadPool that is not unbounded and does not grow as the
number of remoteAddress (clients/peers) are added
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3416
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #702
----
commit 56d7707e12ecdecbc1881a9ac1575fac854e8fe9
Author: Udo Kohlmeyer <ukohlme...@pivotal.io>
Date: 2017-08-09T21:17:59Z
GEODE-3416: Reduce synchronization blockages in SocketCloser.
Remove synchronization blocks around HashMap. Replace that implementation
with simpler ThreadPool that is not unbounded and does not grow as the
number of remoteAddress (clients/peers) are added
----
> Reduce blocking for SocketCloser.asyncClose
> --------------------------------------------
>
> Key: GEODE-3416
> URL: https://issues.apache.org/jira/browse/GEODE-3416
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Affects Versions: 1.1.0, 1.1.1, 1.2.0, 1.2.1
> Reporter: Udo Kohlmeyer
> Assignee: Udo Kohlmeyer
> Fix For: 1.3.0
>
>
> In the SocketCloser.asyncClose method, there is a synchronization block
> around at HashMap. This synchronization will cause an effective
> single-threaded processing capability when closing sockets. this effect
> becomes more evident with a high number of clients.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
