[
https://issues.apache.org/jira/browse/GEODE-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139068#comment-16139068
]
ASF GitHub Bot commented on GEODE-3503:
---------------------------------------
GitHub user kohlmu-pivotal opened a pull request:
https://github.com/apache/geode/pull/736
GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/geode feature/GEODE-3503
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/736.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #736
----
commit 6c807e8267b6ac6878e4b497d0b3d680ea496ef1
Author: Udo Kohlmeyer <ukohlme...@pivotal.io>
Date: 2017-08-23T20:48:11Z
GEODE-3503: Removal of Codec classes left behind.
Added tests to test the remaining JSONCodec.
----
> Remove Codec classes for Protobuf encoded primitives
> ----------------------------------------------------
>
> Key: GEODE-3503
> URL: https://issues.apache.org/jira/browse/GEODE-3503
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Udo Kohlmeyer
> Assignee: Udo Kohlmeyer
>
> As per the initial implementation, the client protocol would encode all
> primitives using specified codecs. To improve on this, all primitives are now
> encoded using protobuf and the codec classes are not required anymore and can
> be removed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
