[ 
https://issues.apache.org/jira/browse/GEODE-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139134#comment-16139134
 ] 

ASF GitHub Bot commented on GEODE-3472:
---------------------------------------

Github user jaredjstewart commented on a diff in the pull request:

    https://github.com/apache/geode/pull/730#discussion_r134872863
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/management/internal/MBeanJMXAdapter.java
 ---
    @@ -72,16 +72,13 @@
       private DistributedMember distMember;
     
       /**
    -   * log writer, or null if there is no distributed system available
    -   */
    -  // private LogWriterI18n logger = 
InternalDistributedSystem.getLoggerI18n();
    -
    -  /**
        * public constructor
        */
     
    +  public static final int VALUE_NOT_AVAILABLE = -1;
    --- End diff --
    
    Should this live in VMStatsMonitor since that's the only place it appears 
to be used?


> Code Cleanup: remove dead code from /management.
> ------------------------------------------------
>
>                 Key: GEODE-3472
>                 URL: https://issues.apache.org/jira/browse/GEODE-3472
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>
> There is a great deal of dead, commented, and unused code in the codebase.  
> This ticket addresses some of it, limiting scope to those files in 
> `geode-core/**/management/**` to keep the eventual diff relatively small.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to