[ https://issues.apache.org/jira/browse/GEODE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208023#comment-16208023 ]
ASF subversion and git services commented on GEODE-3774: -------------------------------------------------------- Commit 63fcc1787413bf66ec3c15ae4fd75a76317b0302 in geode's branch refs/heads/develop from kohlmu-pivotal [ https://gitbox.apache.org/repos/asf?p=geode.git;h=63fcc17 ] GEODE-3774: Amended ProtobufProtocolService.java to create statistics only once. Moved the initialization of statistics for the ClientProtocolService to be inside TCPServer > Remove double-checked Locking in New Client Protocol code > --------------------------------------------------------- > > Key: GEODE-3774 > URL: https://issues.apache.org/jira/browse/GEODE-3774 > Project: Geode > Issue Type: Bug > Components: client/server > Reporter: Galen O'Sullivan > Assignee: Udo Kohlmeyer > > {{ServerConnectionFactory}} uses double-checked locking for loading the > services it depends on. This idiom is fundamentally broken. > Even marking the field that's locked this way {{volatile}} may not resolve > the issue, as the object itself could be read as uninitialized even if the > field (reference) isn't. I don't really know the JMM well enough to be sure > that it's broken, but that's a good sign that we shouldn't do it unless we > really need to for performance reasons (and even then...) > This may be best to resolve after GEODE-3751 and GEODE-3739 due to the > changes to loading those refactors will bring. > While we're at it, we should assert that there is only one client protocol > service, because we can't handle two and which one we choose is undefined. -- This message was sent by Atlassian JIRA (v6.4.14#64029)