[ https://issues.apache.org/jira/browse/GEODE-3335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244221#comment-16244221 ]
ASF GitHub Bot commented on GEODE-3335: --------------------------------------- pdxrunner closed pull request #1034: GEODE-3335: Fix expected member count URL: https://github.com/apache/geode/pull/1034 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java b/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java index c97b83cc7b..3ddb041315 100644 --- a/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java +++ b/geode-core/src/test/java/org/apache/geode/management/RegionManagementDUnitTest.java @@ -68,7 +68,6 @@ import org.apache.geode.management.internal.SystemManagementService; import org.apache.geode.test.dunit.VM; import org.apache.geode.test.junit.categories.DistributedTest; -import org.apache.geode.test.junit.categories.FlakyTest; /** * Distributed tests for {@link RegionMXBean}. @@ -217,7 +216,6 @@ public void testFixedPRRegionMBean() throws Exception { * asynchronously. */ @Test - @Category(FlakyTest.class) // GEODE-1930 public void testRegionAggregate() throws Exception { createManagersAndThenMembers(); @@ -247,7 +245,6 @@ public void testRegionAggregate() throws Exception { } @Test - @Category(FlakyTest.class) // GEODE-3335 public void testNavigationAPIS() throws Exception { createManagersAndThenMembers(); @@ -299,7 +296,6 @@ public void testSpecialRegions() throws Exception { } @Test - @Category(FlakyTest.class) // GEODE-1930 public void testLruStats() throws Exception { createMembersAndThenManagers(); for (VM memberVM : this.memberVMs) { @@ -407,7 +403,8 @@ private void verifyNavigationApis(final VM managerVM, final List<String> memberI ManagementService service = getManagementService(); assertThat(service.getDistributedSystemMXBean()).isNotNull(); - awaitMemberCount(4); + // With the DUnit framework there is a locator, a manager and 3 members + awaitMemberCount(5); DistributedSystemMXBean distributedSystemMXBean = service.getDistributedSystemMXBean(); assertThat(distributedSystemMXBean.listDistributedRegionObjectNames()).hasSize(2); @@ -520,7 +517,7 @@ private void createFixedPartitionRegion( assertThat(fixedPartitionAttributesData).isNotNull(); assertThat(fixedPartitionAttributesData).hasSize(3); - for (int i = 0; i < fixedPartitionAttributesData.length; i++) { + for (FixedPartitionAttributesData aFixedPartitionAttributesData : fixedPartitionAttributesData) { // TODO: add real assertions // LogWriterUtils.getLogWriter().info("<ExpectedString> Fixed PR Data is " + // fixedPartitionAttributesData[i] + "</ExpectedString> "); @@ -971,7 +968,7 @@ private void verifyRemoteFixedPartitionRegion(final VM managerVM) { assertThat(fixedPrData).isNotNull(); assertThat(fixedPrData).hasSize(3); - for (int i = 0; i < fixedPrData.length; i++) { + for (FixedPartitionAttributesData aFixedPrData : fixedPrData) { // TODO: add real assertions // LogWriterUtils.getLogWriter().info("<ExpectedString> Remote PR Data is " + // fixedPrData[i] + "</ExpectedString> "); ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CI Failure : RegionManagementDUnitTest.testNavigationAPIS fails > intermittently with ConditionTimeoutException > ------------------------------------------------------------------------------------------------------------- > > Key: GEODE-3335 > URL: https://issues.apache.org/jira/browse/GEODE-3335 > Project: Geode > Issue Type: Bug > Components: management > Environment: AWS > Reporter: nabarun > Labels: DistributedTest, Flaky > > {noformat} > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.test.dunit.NamedRunnable.run in VM 0 running on Host > 96fffb6d85d3 with 4 VMs > at org.apache.geode.test.dunit.VM.invoke(VM.java:387) > at org.apache.geode.test.dunit.VM.invoke(VM.java:357) > at org.apache.geode.test.dunit.VM.invoke(VM.java:290) > at > org.apache.geode.management.RegionManagementDUnitTest.verifyNavigationApis(RegionManagementDUnitTest.java:419) > at > org.apache.geode.management.RegionManagementDUnitTest.testNavigationAPIS(RegionManagementDUnitTest.java:282) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) > at > org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at > org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) > at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48) > at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) > at org.junit.rules.RunRules.evaluate(RunRules.java:20) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) > at > org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) > at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57) > at > org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66) > at > org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32) > at > org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93) > at com.sun.proxy.$Proxy2.processTestClass(Unknown Source) > at > org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35) > at > org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24) > at > org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377) > at > org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54) > at > org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at java.lang.Thread.run(Thread.java:748) > Caused by: org.awaitility.core.ConditionTimeoutException: Condition defined > as a lambda expression in > org.apache.geode.management.RegionManagementDUnitTest that uses > org.apache.geode.management.DistributedSystemMXBean, > org.apache.geode.management.DistributedSystemMXBeanint expected:<[4]> but > was:<[5]> within 2 minutes. > at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:104) > at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:117) > at > org.awaitility.core.AssertionCondition.await(AssertionCondition.java:32) > at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:809) > at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:648) > at > org.apache.geode.management.RegionManagementDUnitTest.awaitMemberCount(RegionManagementDUnitTest.java:1062) > at > org.apache.geode.management.RegionManagementDUnitTest.lambda$verifyNavigationApis$8ec4a763$1(RegionManagementDUnitTest.java:423) > at org.apache.geode.test.dunit.NamedRunnable.run(NamedRunnable.java:31) > at sun.reflect.GeneratedMethodAccessor13.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at hydra.MethExecutor.executeObject(MethExecutor.java:245) > at > org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70) > at sun.reflect.GeneratedMethodAccessor11.invoke(Unknown Source) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:346) > at sun.rmi.transport.Transport$1.run(Transport.java:200) > at sun.rmi.transport.Transport$1.run(Transport.java:197) > at java.security.AccessController.doPrivileged(Native Method) > at sun.rmi.transport.Transport.serviceCall(Transport.java:196) > at > sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568) > at > sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826) > at > sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683) > at java.security.AccessController.doPrivileged(Native Method) > at > sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682) > ... 3 more > {noformat} -- This message was sent by Atlassian JIRA (v6.4.14#64029)