[
https://issues.apache.org/jira/browse/GEODE-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254169#comment-16254169
]
ASF GitHub Bot commented on GEODE-3341:
---------------------------------------
jinmeiliao commented on a change in pull request #1062: GEODE-3341: Convert
DiskStoreCommandsDUnitTest to use gfsh rules
URL: https://github.com/apache/geode/pull/1062#discussion_r151242266
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DestroyDiskStoreFunction.java
##########
@@ -80,7 +80,6 @@ public void execute(FunctionContext context) {
} catch (VirtualMachineError e) {
Review comment:
I know this is not your change, but would be nice to send an error message
back all the time, instead of having the null message, the above catch block
could be abbreviated to:
catch (IllegalStateException | CacheClosedException ex) {
CliFunctionResult result = new CliFunctionResult(memberId, false,
ex.getMessage());
context.getResultSender().lastResult(result);
} catch (VirtualMachineError e)
.....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Refactor DiskStoreCommandsDUnitTest to use test rules
> -----------------------------------------------------
>
> Key: GEODE-3341
> URL: https://issues.apache.org/jira/browse/GEODE-3341
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 1.2.0
> Reporter: Emily Yeh
> Assignee: Jens Deppe
>
> {{DiskStoreCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a
> deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
