[
https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255662#comment-16255662
]
ASF GitHub Bot commented on GEODE-3539:
---------------------------------------
jinmeiliao commented on a change in pull request #1065: GEODE-3539: Add missing
test coverage to 'list disk-stores' and …
URL: https://github.com/apache/geode/pull/1065#discussion_r151484942
##########
File path:
geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DescribeDiskStoreCommandIntegrationTest.java
##########
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.management.internal.cli.commands;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+import org.apache.geode.test.junit.rules.GfshCommandRule.PortType;
+import org.apache.geode.test.junit.rules.ServerStarterRule;
+
+@Category(IntegrationTest.class)
+public class DescribeDiskStoreCommandIntegrationTest {
+ private static final String REGION_NAME = "test-region";
+ private static final String MEMBER_NAME = "testServer";
+ private static final String DISK_STORE_NAME = "testDiskStore";
+
+ private static final List<String> expectedData = Arrays.asList("Disk Store
ID", "Disk Store Name",
+ "Member ID", "Member Name", "Allow Force Compaction", "Auto Compaction",
+ "Compaction Threshold", "Max Oplog Size", "Queue Size", "Time Interval",
"Write Buffer Size",
+ "Disk Usage Warning Percentage", "Disk Usage Critical Percentage ",
+ "PDX Serialization Meta-Data Stored", "Disk Directory", "Size");
+
+ @ClassRule
+ public static ServerStarterRule server =
+ new ServerStarterRule().withRegion(RegionShortcut.REPLICATE, REGION_NAME)
+
.withName(MEMBER_NAME).withJMXManager().withEmbeddedLocator().withAutoStart();
+
+ @BeforeClass
+ public static void beforeClass() {
+ server.getCache().createDiskStoreFactory().create(DISK_STORE_NAME);
+ }
+
+ @Rule
+ public GfshCommandRule gfsh = new GfshCommandRule();
+
+ @Before
+ public void setTimeout() {
+ gfsh.setTimeout(1);
+ }
+
+ @Test
+ public void commandFailsWithoutOptions() throws Exception {
+ String cmd = "describe disk-store";
+ gfsh.connectAndVerify(server.getEmbeddedLocatorPort(), PortType.locator);
Review comment:
you can put your connectAndVerify in the beforeClass() method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add more test coverage for p2p commands
> ---------------------------------------
>
> Key: GEODE-3539
> URL: https://issues.apache.org/jira/browse/GEODE-3539
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
