[
https://issues.apache.org/jira/browse/GEODE-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259878#comment-16259878
]
ASF GitHub Bot commented on GEODE-2567:
---------------------------------------
jdeppe-pivotal opened a new pull request #1080: GEODE-2567: Add --if-exists to
destroy disk-store
URL: https://github.com/apache/geode/pull/1080
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> gfsh destroy disk-store should be idempotent
> --------------------------------------------
>
> Key: GEODE-2567
> URL: https://issues.apache.org/jira/browse/GEODE-2567
> Project: Geode
> Issue Type: Sub-task
> Components: gfsh
> Reporter: Swapnil Bawaskar
>
> Currently, gfsh {{destroy disk-store}} does *not* throw an error when run
> multiple times:
> {{{
> gfsh>destroy disk-store --name=foo
> Member | Result
> ------ | -----------------------------------
> serv1 | Disk store not found on this member
> serv2 | Disk store not found on this member
> }}}
> However, for a uniform user experience, it should. We should then add a
> {{--if-exists}} option to the command to make it idempotent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
