[ https://issues.apache.org/jira/browse/GEODE-3937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266961#comment-16266961 ]
ASF GitHub Bot commented on GEODE-3937: --------------------------------------- jhuynh1 commented on issue #1002: GEODE-3937:Fix NPE when executing removeFromDisk URL: https://github.com/apache/geode/pull/1002#issuecomment-347223780 I think if you plan on adding a new api you would have to start a discuss topic on the dev list. I would think you would want to add clear to all the gateway sender queues at that point but the change would have to be pretty thoroughly tested. The change to call destroyKey was just a way to show you that the way that it was currently coded in the test code was not correct. I am not sure if it is enough to just call that or if there is other book keeping that needs to be done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Fix NPE when executing removeFromDisk > -------------------------------------- > > Key: GEODE-3937 > URL: https://issues.apache.org/jira/browse/GEODE-3937 > Project: Geode > Issue Type: Bug > Components: wan > Reporter: dinesh akhand > Priority: Trivial > > While executing the test case or clearQueueTestOnly method. we can see > exception > [vm4] java.lang.NullPointerException > [vm4] at > org.apache.geode.internal.cache.entries.DiskEntry$Helper.removeFromDisk(DiskEntry.java:1519) > [vm4] at > org.apache.geode.internal.cache.entries.AbstractOplogDiskRegionEntry.removePhase1(AbstractOplogDiskRegionEntry.java:50) > [vm4] at > org.apache.geode.internal.cache.entries.AbstractRegionEntry.destroy(AbstractRegionEntry.java:914) > [vm4] at > org.apache.geode.internal.cache.AbstractRegionMap.destroyEntry(AbstractRegionMap.java:3100) > [vm4] at > org.apache.geode.internal.cache.AbstractRegionMap.destroy(AbstractRegionMap.java:1429) > [vm4] at > org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6465) > [vm4] at > org.apache.geode.internal.cache.LocalRegion.mapDestroy(LocalRegion.java:6439) > [vm4] at > org.apache.geode.internal.cache.BucketRegion.basicDestroy(BucketRegion.java:1167) > [vm4] at > org.apache.geode.internal.cache.AbstractBucketRegionQueue.basicDestroy(AbstractBucketRegionQueue.java:352) > [vm4] at > org.apache.geode.internal.cache.BucketRegionQueue.basicDestroy(BucketRegionQueue.java:366) > [vm4] at > org.apache.geode.internal.cache.LocalRegion.validatedDestroy(LocalRegion.java:1101) > [vm4] at > org.apache.geode.internal.cache.DistributedRegion.validatedDestroy(DistributedRegion.java:942) > [vm4] at > org.apache.geode.internal.cache.LocalRegion.destroy(LocalRegion.java:1086) > [vm4] at > org.apache.geode.internal.cache.AbstractRegion.destroy(AbstractRegion.java:315) > [vm4] at > org.apache.geode.internal.cache.LocalRegion.remove(LocalRegion.java:8870) > [vm4] at > org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.clearPartitionedRegion(ParallelGatewaySenderQueue.java:1820) > [vm4] at > org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueue.clearQueue(ParallelGatewaySenderQueue.java:1795) > [vm4] at > org.apache.geode.internal.cache.wan.parallel.ConcurrentParallelGatewaySenderQueue.clearQueue(ConcurrentParallelGatewaySenderQueue.java:236) > [vm4] at > org.apache.geode.internal.cache.wan.WANTestBase.clearGatewaySender(WANTestBase.java:256) > [vm4] at > org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueOverflowDUnitTest.lambda$8(ParallelGatewaySenderQueueOverflowDUnitTest.java:96) > [vm4] at > org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueOverflowDUnitTest$$Lambda$42/144498586.run(Unknown > Source) > [vm4] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) -- This message was sent by Atlassian JIRA (v6.4.14#64029)