[
https://issues.apache.org/jira/browse/GEODE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271621#comment-16271621
]
ASF GitHub Bot commented on GEODE-4029:
---------------------------------------
jinmeiliao commented on a change in pull request #1103: GEODE-4029: Deployed
jars may not be correct when multiple locators a…
URL: https://github.com/apache/geode/pull/1103#discussion_r153929128
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterConfigurationService.java
##########
@@ -319,7 +319,13 @@ public boolean addJarsToThisLocator(String[] jarNames,
byte[][] jarBytes, String
// will need the jars on file to upload to other locators. Need to
update the jars
// using a new copy of the Configuration so that the change listener
will pick up the jar
// name changes.
+ // The process happens in 2 phases to cater for the situation where an
existing jar is only
+ // updated.
+
Configuration configurationCopy = new Configuration(configuration);
+ configurationCopy.removeJarNames(jarNames);
Review comment:
we don't need to this in 2 phases now, just the add since we are getting all
the existing jar files from locators anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Deployed jars may not be correct when multiple locators are in use
> ------------------------------------------------------------------
>
> Key: GEODE-4029
> URL: https://issues.apache.org/jira/browse/GEODE-4029
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Jens Deppe
> Assignee: Jens Deppe
>
> When we have more than one locator, if a jar is re-deployed it will not be
> propagated correctly to the 'remote' locators. i.e. the locators which are
> not directly executing the 'deploy' command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
