[
https://issues.apache.org/jira/browse/GEODE-2665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277037#comment-16277037
]
ASF GitHub Bot commented on GEODE-2665:
---------------------------------------
jinmeiliao commented on a change in pull request #1116: GEODE-2665: Add Gfsh
command to delete async event queues
URL: https://github.com/apache/geode/pull/1116#discussion_r154698337
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DestroyAsyncEventQueueCommand.java
##########
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import static
org.apache.geode.management.internal.cli.i18n.CliStrings.IFEXISTS;
+import static
org.apache.geode.management.internal.cli.i18n.CliStrings.IFEXISTS_HELP;
+
+import java.util.List;
+import java.util.Set;
+
+import org.springframework.shell.core.annotation.CliCommand;
+import org.springframework.shell.core.annotation.CliOption;
+
+import org.apache.geode.cache.execute.Function;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.management.cli.ConverterHint;
+import org.apache.geode.management.cli.Result;
+import org.apache.geode.management.internal.cli.functions.CliFunctionResult;
+import
org.apache.geode.management.internal.cli.functions.DestroyAsyncEventQueueFunction;
+import
org.apache.geode.management.internal.cli.functions.DestroyAsyncEventQueueFunctionArgs;
+import org.apache.geode.management.internal.cli.i18n.CliStrings;
+import org.apache.geode.management.internal.cli.result.ResultBuilder;
+import org.apache.geode.management.internal.cli.result.TabularResultData;
+import org.apache.geode.management.internal.security.ResourceOperation;
+import org.apache.geode.security.ResourcePermission;
+
+public class DestroyAsyncEventQueueCommand implements GfshCommand {
+ public static final String DESTROY_ASYNC_EVENT_QUEUE = "destroy
async-event-queue";
+ public static final String DESTROY_ASYNC_EVENT_QUEUE__HELP = "destroy an
Async Event Queue";
+ public static final String DESTROY_ASYNC_EVENT_QUEUE__ID = "id";
+ public static final String DESTROY_ASYNC_EVENT_QUEUE__ID__HELP =
+ "ID of the queue to be destroyed.";
+ public static final String DESTROY_ASYNC_EVENT_QUEUE__GROUP__HELP =
+ "Group(s) of members on which to destroy the async event queue.";
+
+ public static final String DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_NOT_FOUND =
+ "Async event queue \"%s\" not found";
+ public static final String DESTROY_ASYNC_EVENT_QUEUE__AEQ_0_DESTROYED =
+ "Async event queue \"%s\" destroyed";
+
+ @CliCommand(value = DESTROY_ASYNC_EVENT_QUEUE, help =
DESTROY_ASYNC_EVENT_QUEUE__HELP)
+ @ResourceOperation(resource = ResourcePermission.Resource.CLUSTER,
+ operation = ResourcePermission.Operation.MANAGE)
+ public Result destroyAsyncEventQueue(
+ @CliOption(key = DESTROY_ASYNC_EVENT_QUEUE__ID, mandatory = true,
+ help = DESTROY_ASYNC_EVENT_QUEUE__ID__HELP) String aeqId,
+ @CliOption(key = {CliStrings.GROUP, CliStrings.GROUPS},
+ optionContext = ConverterHint.MEMBERGROUP,
+ help = DESTROY_ASYNC_EVENT_QUEUE__GROUP__HELP) String[] onGroups,
+ @CliOption(key = IFEXISTS, help = IFEXISTS_HELP, specifiedDefaultValue =
"true",
+ unspecifiedDefaultValue = "false") boolean ifExists) {
+ DestroyAsyncEventQueueFunctionArgs asyncEventQueueDestoryFunctionArgs =
+ new DestroyAsyncEventQueueFunctionArgs(aeqId, ifExists);
+
+ Set<DistributedMember> members = getMembers(onGroups, null);
+
+ List<CliFunctionResult> functionResults =
+ execute(new DestroyAsyncEventQueueFunction(),
asyncEventQueueDestoryFunctionArgs, members);
+
+ TabularResultData tabularResultData =
ResultBuilder.createTabularResultData();
+ boolean errorOccurred = false;
+ for (CliFunctionResult functionResult : functionResults) {
+ LogService.getLogger().info("FunctionResult = '" + functionResult + "'");
+ tabularResultData.accumulate("Member",
functionResult.getMemberIdOrName());
+ if (functionResult.isSuccessful()) {
+ tabularResultData.accumulate("Status", functionResult.getMessage());
+ } else {
+ // if result has exception, it will be logged by the server before
throwing it.
+ // so we don't need to log it here anymore.
+ tabularResultData.accumulate("Status", "ERROR: " +
functionResult.getErrorMessage());
+ errorOccurred = true;
+ }
+ }
+ tabularResultData.setStatus(errorOccurred ? Result.Status.ERROR :
Result.Status.OK);
Review comment:
You will need to update the cluster configuration as well. Have your
function return an xmlEntity, and call a
clusterConfigService.deleteXmlEntity(). Use DestroyRegionCommand as an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add gfsh command to destroy async-event-queue
> ---------------------------------------------
>
> Key: GEODE-2665
> URL: https://issues.apache.org/jira/browse/GEODE-2665
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
> Assignee: Kenneth Howe
> Fix For: 1.4.0
>
>
> Currently, there is only an {{create async-event-queue}} command in gfsh, we
> need the corresponding {{destroy async-event-queue}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
