[
https://issues.apache.org/jira/browse/GEODE-4049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278851#comment-16278851
]
ASF GitHub Bot commented on GEODE-4049:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #1118: GEODE-4049:
refactor CreateRegionCommand and DestoryRegionCommand status
URL: https://github.com/apache/geode/pull/1118#discussion_r155009037
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/execute/FunctionContext.java
##########
@@ -77,4 +80,22 @@
public boolean isPossibleDuplicate();
public Cache getCache();
+
+ /**
+ * a convenience method to get the name of the member this function executes
on. call this
+ * function once in your function execution to avoid performance issues.
+ *
+ * @return member name or id if name is blank
+ */
+ public default String getMemberName() {
Review comment:
I can see how it would help with mocking/testing, but it still smells a bit
to me. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Command that executes function on multiple members should report the status
> of execution on each member
> -------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4049
> URL: https://issues.apache.org/jira/browse/GEODE-4049
> Project: Geode
> Issue Type: Bug
> Reporter: Jinmei Liao
>
> "destroy region", even though executes function on multiple members, do not
> report the result as tabular results. Need to change that.
> The tabular results of these commands should be successful if at least one
> member executes successfully. Cluster config should be updated if one
> function gets executed successfully.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
