[
https://issues.apache.org/jira/browse/GEODE-3964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279166#comment-16279166
]
ASF GitHub Bot commented on GEODE-3964:
---------------------------------------
galen-pivotal commented on a change in pull request #1088: GEODE-3964: More
logging for suspect processing.
URL: https://github.com/apache/geode/pull/1088#discussion_r155071214
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/ReplyProcessor21.java
##########
@@ -139,43 +140,35 @@
protected final DM dmgr;
/** Start time for replyWait stat, in nanos */
- protected long statStart;
+ long statStart;
/** Start time for ack-wait-threshold, in millis */
- protected long initTime;
+ private long initTime;
/**
* whether this reply processor should perform severe-alert processing for
the message being ack'd
*/
- protected boolean severeAlertEnabled;
+ private boolean severeAlertEnabled;
/**
* whether the severe-alert timeout has been reset. This can happen if a
member we're waiting for
* is waiting on a suspect member, for instance.
*/
- protected volatile boolean severeAlertTimerReset;
+ private volatile boolean severeAlertTimerReset;
/**
* whether this reply processor should shorten severe-alert processing due
to another vm waiting
* on this one. This is a thread-local so that lower level comm layers can
tell that the interval
* should be shortened
*/
- public static final ThreadLocal SevereAlertShorten = new ThreadLocal() {
- @Override
- protected Object initialValue() {
- return Boolean.FALSE;
- }
- };
+ private static final ThreadLocal<Boolean> SevereAlertShorten =
Review comment:
Probably not. I didn't even know that was a word.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add another severe-alert option
> -------------------------------
>
> Key: GEODE-3964
> URL: https://issues.apache.org/jira/browse/GEODE-3964
> Project: Geode
> Issue Type: Bug
> Components: messaging
> Reporter: Bruce Schuchardt
>
> Since suspect processing only commences when the ack-severe-alert-threshold
> is reached it would be nice to have yet another alert if that processing
> failed to kick out the slow-to-respond member and a thread is stuck for a
> long time waiting for a reply.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
