[
https://issues.apache.org/jira/browse/GEODE-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299214#comment-16299214
]
ASF GitHub Bot commented on GEODE-4125:
---------------------------------------
jhuynh1 closed pull request #1188: GEODE-4125: Add correct runner to query and
wan tests
URL: https://github.com/apache/geode/pull/1188
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
index afc1dbc9ba..13bb545b18 100644
---
a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
+++
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandTest.java
@@ -41,7 +41,9 @@
import org.apache.geode.test.junit.categories.IntegrationTest;
import org.apache.geode.test.junit.rules.GfshCommandRule;
import org.apache.geode.test.junit.rules.ServerStarterRule;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category(IntegrationTest.class)
@RunWith(Parameterized.class)
public class QueryCommandTest {
diff --git
a/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
index ea0f92074d..2488675cb1 100644
---
a/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/security/query/IndexSecurityDUnitTest.java
@@ -18,11 +18,6 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.fail;
-import java.util.Arrays;
-import java.util.List;
-
-import junitparams.JUnitParamsRunner;
-import junitparams.Parameters;
import org.junit.Before;
import org.junit.Test;
import org.junit.experimental.categories.Category;
@@ -36,7 +31,9 @@
import org.apache.geode.security.query.data.QueryTestObject;
import org.apache.geode.test.junit.categories.DistributedTest;
import org.apache.geode.test.junit.categories.SecurityTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category({DistributedTest.class, SecurityTest.class})
@RunWith(Parameterized.class)
public class IndexSecurityDUnitTest extends QuerySecurityBase {
diff --git
a/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
index 593bd4e280..e79113739f 100644
---
a/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/security/query/PartitionedIndexSecurityDUnitTest.java
@@ -14,7 +14,6 @@
*/
package org.apache.geode.security.query;
-import junitparams.JUnitParamsRunner;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
@@ -22,7 +21,9 @@
import org.apache.geode.cache.RegionShortcut;
import org.apache.geode.test.junit.categories.DistributedTest;
import org.apache.geode.test.junit.categories.SecurityTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category({DistributedTest.class, SecurityTest.class})
@RunWith(Parameterized.class)
public class PartitionedIndexSecurityDUnitTest extends IndexSecurityDUnitTest {
diff --git
a/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
index b9d0fda099..8155d4ba10 100644
---
a/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/security/query/PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
@@ -21,7 +21,9 @@
import org.apache.geode.cache.RegionShortcut;
import org.apache.geode.test.junit.categories.DistributedTest;
import org.apache.geode.test.junit.categories.SecurityTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category({DistributedTest.class, SecurityTest.class})
@RunWith(Parameterized.class)
public class PdxPartitionedQuerySecurityAllowedQueriesDUnitTest
diff --git
a/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityAllowedQueriesDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityAllowedQueriesDUnitTest.java
index e25f6cf636..25fe6325cb 100644
---
a/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityAllowedQueriesDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityAllowedQueriesDUnitTest.java
@@ -14,25 +14,21 @@
*/
package org.apache.geode.security.query;
-import java.io.Serializable;
-import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
-import junitparams.Parameters;
import org.junit.Before;
import org.junit.Test;
import org.junit.experimental.categories.Category;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
-import org.apache.geode.pdx.PdxReader;
-import org.apache.geode.pdx.PdxSerializable;
-import org.apache.geode.pdx.PdxWriter;
import org.apache.geode.security.query.data.PdxQueryTestObject;
import org.apache.geode.test.junit.categories.DistributedTest;
import org.apache.geode.test.junit.categories.SecurityTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category({DistributedTest.class, SecurityTest.class})
@RunWith(Parameterized.class)
public class PdxQuerySecurityAllowedQueriesDUnitTest extends QuerySecurityBase
{
diff --git
a/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityRestrictedQueriesDUnitTest.java
b/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityRestrictedQueriesDUnitTest.java
index f7e025893c..bfa94d3910 100644
---
a/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityRestrictedQueriesDUnitTest.java
+++
b/geode-core/src/test/java/org/apache/geode/security/query/PdxQuerySecurityRestrictedQueriesDUnitTest.java
@@ -32,7 +32,9 @@
import org.apache.geode.security.query.data.PdxQueryTestObject;
import org.apache.geode.test.junit.categories.DistributedTest;
import org.apache.geode.test.junit.categories.SecurityTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category({DistributedTest.class, SecurityTest.class})
@RunWith(Parameterized.class)
public class PdxQuerySecurityRestrictedQueriesDUnitTest extends
QuerySecurityBase {
diff --git
a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/GatewayReceiverFactoryImplJUnitTest.java
b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/GatewayReceiverFactoryImplJUnitTest.java
index 7b88477c07..179d24c80e 100644
---
a/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/GatewayReceiverFactoryImplJUnitTest.java
+++
b/geode-wan/src/test/java/org/apache/geode/internal/cache/wan/GatewayReceiverFactoryImplJUnitTest.java
@@ -40,7 +40,9 @@
import org.apache.geode.internal.cache.InternalCache;
import org.apache.geode.internal.cache.xmlcache.CacheCreation;
import org.apache.geode.test.junit.categories.UnitTest;
+import
org.apache.geode.test.junit.runners.CategoryWithParameterizedRunnerFactory;
+@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)
@Category(UnitTest.class)
@RunWith(Parameterized.class)
public class GatewayReceiverFactoryImplJUnitTest {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add correct runner to query and wan tests
> -----------------------------------------
>
> Key: GEODE-4125
> URL: https://issues.apache.org/jira/browse/GEODE-4125
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Reporter: Jason Huynh
> Assignee: Jason Huynh
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
