[
https://issues.apache.org/jira/browse/GEODE-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308910#comment-16308910
]
ASF subversion and git services commented on GEODE-4122:
--------------------------------------------------------
Commit 0f8cd8e1ef12ab864f5b2ae7a0556156b249b432 in geode's branch
refs/heads/develop from [~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0f8cd8e ]
GEODE-4122: Add runner annotation to avoid skipping tests with Parameterized
* GEODE-4122: Add runner annotation to avoid skipping tests with Parameterized
* Optimize imports in touched files.
* Fix small error in GcCommandDUnitTest in error phrasing
* The following will be corrected in separate tickets:
* - QueryCommandTest
* - ShutdownCommandDUnitTest
* - CacheServerSSLConnectionDUnitTest
> Parameterized tests are skipped when not run with correct runner factory
> ------------------------------------------------------------------------
>
> Key: GEODE-4122
> URL: https://issues.apache.org/jira/browse/GEODE-4122
> Project: Geode
> Issue Type: Bug
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Labels: testing
>
> Initial bug in GEODE-1350, tests annotated with
> {{@RunWith(Parameterized.class)}} are not correctly detected during testing.
> This is corrected when the test class also contains the annotation
> {{@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)}}.
> The following is an possibly-incomplete list of tests containing the
> offending {{@RunWith}} annotation but not the correcting
> {{@Parameterized.UseParametersRunnerFactory}} annotation, matching on the
> regex {{@RunWith\(Parameterized\.class\)\n(?!@Parameterized)}}
> {noformat}
> BaseStringConverterJUnitTest.java
> CacheServerSSLConnectionDUnitTest.java
> ChangeLogLevelCommandDUnitTest.java
> ClusterConfigurationDUnitTest.java
> GatewayReceiverFactoryImplJUnitTest.java
> GcCommandDUnitTest.java
> IndexSecurityDUnitTest.java
> PartitionedIndexSecurityDUnitTest.java
> PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
> PdxQuerySecurityAllowedQueriesDUnitTest.java
> PdxQuerySecurityRestrictedQueriesDUnitTest.java
> PRCacheListenerInvocationTest.java
> PRCacheListenerWithInterestPolicyAllInvocationTest.java
> PulseConnectivityTest.java
> QueryCommandTest.java
> ShowLogCommandDUnitTest.java
> ShutdownCommandDUnitTest.java
> {noformat}
> Closure of this ticket should also include a UnitTest or extension to the
> {{test.gradle}} that ensures no future test includes the one annotation
> without the other.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
