[ 
https://issues.apache.org/jira/browse/GEODE-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310163#comment-16310163
 ] 

ASF GitHub Bot commented on GEODE-4158:
---------------------------------------

PivotalSarge opened a new pull request #1219: GEODE-4158: Correct the detection 
of Geode-internal classes for seria…
URL: https://github.com/apache/geode/pull/1219
 
 
   …lization.
   
   - Remove consideration of any class under org.apache as a Geode-internal
     class that resulted from a search-and-replace.
   
   Signed-off-by: Dan Smith <dsm...@pivotal.io>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [X] Have you written or updated unit tests to verify your changes?
   
   - [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   
   @upthewaterspout @WireBaron @bschuchardt @galen-pivotal 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Serialization does not correctly identify Geode-internal classes
> ----------------------------------------------------------------
>
>                 Key: GEODE-4158
>                 URL: https://issues.apache.org/jira/browse/GEODE-4158
>             Project: Geode
>          Issue Type: Bug
>          Components: serialization
>            Reporter: Michael Dodge
>
> Reflection-based auto-serialization respects a system property, 
> "gemfire.auto.serialization.no.hardcoded.excludes", with regard to excluding 
> Geode-internal classes from auto-serialization. However, 
> {{InternalDataSerializer}} does not respect that system property and uses 
> overly-aggressive prefix matching. For example, {{InternalDataSerializer}} 
> should not consider classes under {{org.apache.geode_examples}} to be 
> Geode-internal classes as they are from the examples.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to