[ 
https://issues.apache.org/jira/browse/GEODE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319429#comment-16319429
 ] 

Darrel Schneider commented on GEODE-4198:
-----------------------------------------

DiskStoreMonitor needs to know the configured log directory and gets it like so:
{noformat}
  private File getLogDir() {
    File log = null;
    InternalCache internalCache = GemFireCacheImpl.getInstance();
    if (internalCache != null) {
      InternalDistributedSystem ds = 
internalCache.getInternalDistributedSystem();
      if (ds != null) {
        DistributionConfig conf = ds.getConfig();
        if (conf != null) {
          log = conf.getLogFile();
          if (log != null) {
            log = log.getParentFile();
          }
        }
      }
    }
{noformat}
It calls this method from its constructor which is called from GemFireCacheImpl.
It seems better for the constructor to take the configured log directory as a 
File parameter which GemFireCacheImpl can do since it was passed an 
InternalDistributedSystem.


> DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance
> ---------------------------------------------------------------
>
>                 Key: GEODE-4198
>                 URL: https://issues.apache.org/jira/browse/GEODE-4198
>             Project: Geode
>          Issue Type: Sub-task
>          Components: persistence
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>
> DiskStoreMonitor should not invoke GemFireCacheImpl.getInstance



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to