[ 
https://issues.apache.org/jira/browse/GEODE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329086#comment-16329086
 ] 

ASF GitHub Bot commented on GEODE-4298:
---------------------------------------

PurelyApplied closed pull request #1286: GEODE-4298: Restore public access to 
StartServer method.
URL: https://github.com/apache/geode/pull/1286
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java 
b/geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java
index b9f575abb7..9826c35fb5 100755
--- a/geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/ServerLauncher.java
@@ -891,7 +891,7 @@ boolean isWaiting(final Cache cache) {
   /**
    * Causes the calling Thread to block until the GemFire Cache Server/Data 
Member stops.
    */
-  void waitOnServer() {
+  public void waitOnServer() {
     assert getCache() != null : "The Cache Server must first be started with a 
call to start!";
 
     if (!isServing(getCache())) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> ServerLauncher.waitOnServer has inadvertent public API change
> -------------------------------------------------------------
>
>                 Key: GEODE-4298
>                 URL: https://issues.apache.org/jira/browse/GEODE-4298
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Patrick Rhomberg
>            Priority: Major
>              Labels: pull-request-available
>
> A public method was made package protected.  This should be returned to 
> public until a major release, if at all.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to