[ 
https://issues.apache.org/jira/browse/GEODE-4637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob S. Barrett updated GEODE-4637:
------------------------------------
    Description: 
The java side of things uses {{GEODE_HOME}} environment variable to point to 
the Geode install directory containing the /bin.

[https://github.com/apache/geode-examples/blob/5b413a34e30790a6631332cfa1f4b485a487abcb/build.gradle]

Geode Native uses the environment variable GEODE. 
 [https://github.com/apache/geode-native/blob/develop/BUILDING.md]

This is confusing. It would be best if we standardize on {{GEODE_HOME}}.

 

This does not mean changing the FindGeode.cmake module's {{GEODE_ROOT}} 
configuration variable. The only change should be in which environment variable 
is used to search for Geode if the {{GEODE_ROOT}} is not explicitly set.

  was:
The java side of things uses GEODE_HOME to point to the Geode install directory 
containing the /bin.

[https://github.com/apache/geode-examples/blob/5b413a34e30790a6631332cfa1f4b485a487abcb/build.gradle]

Geode Native uses the env variable GEODE. 
 [https://github.com/apache/geode-native/blob/develop/BUILDING.md]

This is confusing. It would be best if we standardize on GEODE_HOME.

 

This does not mean changing the FindGeode.cmake module's `GEODE_ROOT` 
configuration variable. The only change should be in which environment variable 
is used to search for Geode if the `GEODE_ROOT` is not explicitly set.


> Geode Native uses GEODE rather than GEODE_HOME
> ----------------------------------------------
>
>                 Key: GEODE-4637
>                 URL: https://issues.apache.org/jira/browse/GEODE-4637
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Addison
>            Assignee: Michael Oleske
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The java side of things uses {{GEODE_HOME}} environment variable to point to 
> the Geode install directory containing the /bin.
> [https://github.com/apache/geode-examples/blob/5b413a34e30790a6631332cfa1f4b485a487abcb/build.gradle]
> Geode Native uses the environment variable GEODE. 
>  [https://github.com/apache/geode-native/blob/develop/BUILDING.md]
> This is confusing. It would be best if we standardize on {{GEODE_HOME}}.
>  
> This does not mean changing the FindGeode.cmake module's {{GEODE_ROOT}} 
> configuration variable. The only change should be in which environment 
> variable is used to search for Geode if the {{GEODE_ROOT}} is not explicitly 
> set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to