[ 
https://issues.apache.org/jira/browse/GEODE-5187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472353#comment-16472353
 ] 

ASF subversion and git services commented on GEODE-5187:
--------------------------------------------------------

Commit 98c7eaec4cb656e36a1a165a7bb0ec57b0603c90 in geode's branch 
refs/heads/feature/GEODE-5187 from [~lhughesgodfrey]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=98c7eae ]

GEODE-5187: clients can miss events when servers recycled

* When draining events from the giiQueue, the msg field of HAEventWrapper may 
be null.
  Update the HAEventWrapper to point to the message in the HAContainer vs. 
calling
  putEventInHARegion with the original HAContainer message (a 
ClientUpdateMessageImpl).
  This is necessary as the ClientUpdateMessageImpl does not have the eventId 
(this is not
  serialized/deserialized in toData/fromData).  The HAEventWrapper is required 
on the
  remote side to reconstruct the event.

* Updated log messages to include the HARegionQueue.regionName

* Added corresponding IntegrationTest


> clients can miss events when servers recycled, possibly due to null eventId 
> in ClientUpdateMessageImpl
> ------------------------------------------------------------------------------------------------------
>
>                 Key: GEODE-5187
>                 URL: https://issues.apache.org/jira/browse/GEODE-5187
>             Project: Geode
>          Issue Type: Bug
>          Components: client queues
>            Reporter: Shelley Lynn Hughes-Godfrey
>            Assignee: Shelley Lynn Hughes-Godfrey
>            Priority: Major
>
> HARegionQueues may have an issue where messages are lost due to the eventId 
> (threadId and sequenceId) being null ... which prevents them from being 
> dispatched to the client.
> This may be due to the ClientUpdateMessageImpl no longer including the 
> eventId when serialized over the wire between servers.  Now the receiving 
> side must use eventId from the HAEventWrapper to re-populate this field in 
> the ClientUpdateMessage. 
> If the null eventId is detected by HARegionQueue.putGIIDataInRegion, the 
> corresponding event is silently dropped.  This occurs when processing the 
> InitialImage of the HARegionQueue from another server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to