[ https://issues.apache.org/jira/browse/GEODE-5405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537855#comment-16537855 ]
ASF subversion and git services commented on GEODE-5405: -------------------------------------------------------- Commit 24814d37fca8b8fa3efe57cc885f4c0d9e3b3761 in geode's branch refs/heads/feature/GEODE-5404 from [~barry.oglesby] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=24814d3 ] GEODE-5405: Removed static block, renamed test class > Refactor backup code to remove duplication and improve understanding > -------------------------------------------------------------------- > > Key: GEODE-5405 > URL: https://issues.apache.org/jira/browse/GEODE-5405 > Project: Geode > Issue Type: Improvement > Components: persistence > Reporter: Kirk Lund > Assignee: Kirk Lund > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > * FlushToDiskBackupStep should extend (abstract) BackupStep. This will remove > some duplication. > * BackupService has a non-private field which should be encapsulated > (currentTask). > * validateRequestingAdmin should be renamed to validateRequestingSender in > BackupService. > * Cleanup and streamline integration and distributed tests in backup package. > * Introduce new backup config that doesn't use constants and properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)